Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Change 'create multi-layer map' title to be use-case focused #89520

Merged
merged 8 commits into from
Feb 2, 2021

Conversation

kmartastic
Copy link
Contributor

[Maps] Change 'create multi-layer map' title to be use-case focused.

No other changes as the topic has been updated recently to simplify the intro/summary text.

@kmartastic kmartastic added Team:Docs [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Jan 28, 2021
@kmartastic kmartastic requested review from nreese and gchaps January 28, 2021 00:32
@kmartastic kmartastic self-assigned this Jan 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmartastic I like this new title.

When we move to the new docs system, we won't be using wording like "Step 1" and "Step 2" in our section titles. Do you want to remove that wording in this PR too?

@@ -1,9 +1,9 @@
[role="xpack"]
[[maps-getting-started]]
== Create a map with multiple layers and data sources
== Build, analyze, and share a map to compare metrics by country or region
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "share" in Kibana has specific meaning in Kibana tied to reporting, embedding, and creating URLs. See below for the UI in Dashboard. This tutorial does not cover sharing in this traditional sense. How about "Build, analyze, and add a map to a dashboard to compare metrics by country or region"?

Screen Shot 2021-01-28 at 8 33 02 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Analyze" and "compare" seem the same to me. What if the title were a little simpler:

Build a map to compare metrics by country or region

@@ -68,9 +68,9 @@ To enable a blended layer that dynamically shows clusters or documents:

[role="xpack"]
[[maps-top-hits-aggregation]]
=== Top hits per entity
=== Display the most relevant entities
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your changes from your other PR made it into this PR. How about reverting changes to this file since there is an open PR to make these changes?

@kmartastic
Copy link
Contributor Author

@elasticmachine merge upstream

@kmartastic kmartastic requested a review from nreese January 29, 2021 21:22
@kmartastic kmartastic merged commit 2b0053a into elastic:master Feb 2, 2021
gmmorris added a commit to lizozom/kibana that referenced this pull request Feb 2, 2021
…om/kibana into pr/89570

* 'sessions/save-all-sessions' of https://github.com/lizozom/kibana: (44 commits)
  [ML] Functional tests - skip DFA clone tests
  [Uptime] Fix synthetics detail step count (elastic#89940)
  Fixes the permissions to require cluster.manage in order to create an index and in order to update an index (elastic#89947)
  [Security Solution] [Detections] adds log info level for logging in cloud (elastic#89941)
  [Time to Visualize] Dashboard By Value Testing Lens (elastic#89581)
  [Uptime] Expand synthetic journey step thumbnail on hover (elastic#89179)
  TS project refs: Migrates snapshot_restore to a TS Project (elastic#89653)
  docs: APM 7.11 updates (elastic#89789)
  move skip to higher level (elastic#86952)
  Revert "Migrations v2: don't auto-create indices + FTR/esArchiver support (elastic#85778)"
  Revert "Revert "Enable v2 so migrations, disable in FTR tests (elastic#89297)""
  Revert "Enable v2 so migrations, disable in FTR tests (elastic#89297)"
  [data.search] Allow search response to follow new hits format (elastic#88115)
  [Maps] Change 'create multi-layer map' title to be use-case focused (elastic#89520)
  skip flaky suite (elastic#86952)
  [Security Solution] Remove focustrap (elastic#89905)
  [Workplace Search] Add remaining i18n support for the Content Sources tree (elastic#89910)
  [esArchiver] log when migrations complete and we're done loading data (elastic#89938)
  Add --ssl flag to make resolver generator use ssl with kbn and elasticsearch clients (elastic#89873)
  TS project refs: Migrates grokdebugger (elastic#89652)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 4, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 89520 or prevent reminders by adding the backport:skip label.

kmartastic added a commit to kmartastic/kibana that referenced this pull request Feb 4, 2021
…lastic#89520)

* [maps] Top hits per entity--change to title to use recent, minor edits

* Updated TopHitsPerEntity title and description to use the term relevant

* Change create multi-layer map tutorial title to be use-case driven

* reverting change to TopHits topic

* Updated title of getting started with maps tutorial

* Updated title of getting started with maps tutorial

Co-authored-by: Kent Marten <kmartastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kmartastic added a commit to kmartastic/kibana that referenced this pull request Feb 4, 2021
…lastic#89520)

* [maps] Top hits per entity--change to title to use recent, minor edits

* Updated TopHitsPerEntity title and description to use the term relevant

* Change create multi-layer map tutorial title to be use-case driven

* reverting change to TopHits topic

* Updated title of getting started with maps tutorial

* Updated title of getting started with maps tutorial

Co-authored-by: Kent Marten <kmartastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kmartastic added a commit that referenced this pull request Feb 4, 2021
…89520) (#90352)

* [maps] Top hits per entity--change to title to use recent, minor edits

* Updated TopHitsPerEntity title and description to use the term relevant

* Change create multi-layer map tutorial title to be use-case driven

* reverting change to TopHits topic

* Updated title of getting started with maps tutorial

* Updated title of getting started with maps tutorial

Co-authored-by: Kent Marten <kmartastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kent Marten <kmartastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kmartastic added a commit that referenced this pull request Feb 4, 2021
…89520) (#90351)

* [maps] Top hits per entity--change to title to use recent, minor edits

* Updated TopHitsPerEntity title and description to use the term relevant

* Change create multi-layer map tutorial title to be use-case driven

* reverting change to TopHits topic

* Updated title of getting started with maps tutorial

* Updated title of getting started with maps tutorial

Co-authored-by: Kent Marten <kmartastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kent Marten <kmartastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants