Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Prevent permissions checks from being bypassed when indices do not exist #89664

Closed
wants to merge 2 commits into from
Closed

[Security Solution][Detections] Prevent permissions checks from being bypassed when indices do not exist #89664

wants to merge 2 commits into from

Commits on Jan 29, 2021

  1. Prevent permissions checks from being bypassed due to DNE indices 

    Specifying this option meant that our field_capabilities check was
throwing an error if the rule included an index pattern that did not
exist. This would be most typical in e.g. a prepackaged rule using
the default index patterns.

While we rescued this error and continued rule execution, this had the
side effect of skipping the remaining permissions checks, both of which
would have potentially written a partial failure status to the rule.

P.S. the original motivation for this PR was removing the confusing
error that this option caused; it was only after exploration that this
side effect was discovered.
    @rylnd
    rylnd committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    87ad318 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-permissions-index-error

    @kibanamachine
    kibanamachine authored Jan 29, 2021
    Configuration menu
    Copy the full SHA
    53160cb View commit details
    Browse the repository at this point in the history