Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upgrade Assistant] Use kibana version value from core context #89774

Merged
merged 6 commits into from
Feb 1, 2021
Merged

[Upgrade Assistant] Use kibana version value from core context #89774

merged 6 commits into from
Feb 1, 2021

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Jan 29, 2021 •
edited
Loading

Related to #89321

This PR utilizes PluginInitializerContext.env.packageInfo.version to read the kibana version, instead of importing package.json. This work unblocks the migration of UA to TS project references.

@alisonelizabeth alisonelizabeth added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v7.12.0 labels Jan 29, 2021
@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor

@alisonelizabeth This is looking great!

@alisonelizabeth alisonelizabeth marked this pull request as ready for review February 1, 2021 14:47
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner February 1, 2021 14:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor Author

Thanks @TinaHeiligers! This is ready for review if you'd like to take a look.

sebelga
sebelga approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did not test locally. Great job @alisonelizabeth !

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
upgradeAssistant 121 119 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 135.8KB 136.4KB +564.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 57.7KB 33.4KB -24.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for getting this in so quickly 😄

@alisonelizabeth alisonelizabeth merged commit 6ea5889 into elastic:master Feb 1, 2021
@alisonelizabeth alisonelizabeth deleted the ua/ts_project_prereq branch February 1, 2021 19:47
@alisonelizabeth alisonelizabeth mentioned this pull request Feb 1, 2021
Merged
alisonelizabeth added a commit that referenced this pull request Feb 2, 2021
@alisonelizabeth
[7.x] [Upgrade Assistant] Use kibana version value from core context (#…
d45e242 
…89774) (#89918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
chore Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alisonelizabeth @TinaHeiligers @elasticmachine @kibanamachine @sebelga