Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): support yarn install using bazel managed directories for dependencies #89883

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Feb 1, 2021

One step forward on #69706

That makes preinstall_check.js able to work with the future Bazel managed dependencies by allowing an yarn install that is also running with the env BAZEL_YARN_INSTALL flag.

@mistic mistic added chore Team:Operations Team label for Operations Team build v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 1, 2021
@mistic mistic requested a review from tylersmalley February 1, 2021 16:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic changed the title Support install yarn deps with bazel chore(NA): support yarn install using bazel managed directories for dependencies Feb 1, 2021
@mistic
Copy link
Member Author

mistic commented Feb 2, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit a9e6c39 into elastic:master Feb 2, 2021
@mistic
Copy link
Member Author

mistic commented Feb 2, 2021

7.x/7.12: 332c9c1

mistic added a commit to mistic/kibana that referenced this pull request Feb 2, 2021
…ependencies (elastic#89883)

* chore(NA): allow yarn dependencies to be installed when using bazel to manage yarn deps

* chore(NA): remove unused flag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mistic added a commit that referenced this pull request Feb 2, 2021
…ependencies (#89883) (#89983)

* chore(NA): allow yarn dependencies to be installed when using bazel to manage yarn deps

* chore(NA): remove unused flag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@mistic mistic mentioned this pull request Feb 3, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants