Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Detections] Remove allow_no_indices to prevent error being thrown in response of field capabilities #89927

Merged
merged 5 commits into from
Feb 2, 2021
Merged

[Security Solution] [Detections] Remove allow_no_indices to prevent error being thrown in response of field capabilities #89927

merged 5 commits into from
Feb 2, 2021

Commits on Feb 2, 2021

  1. remove allow_no_indices param, adds a check if response has empty ind… 

    …ices property then write error status with index patterns provided to rule
    @dhurley14
    dhurley14 committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    425dd32 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @dhurley14
    dhurley14 committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    80a296b View commit details
    Browse the repository at this point in the history

  3. fix tests and update with comments

    @dhurley14
    dhurley14 committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    6433552 View commit details
    Browse the repository at this point in the history

  4. update integration tests

    @dhurley14
    dhurley14 committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    76017b8 View commit details
    Browse the repository at this point in the history

  5. adds integration test for when an index pattern doesn't exist the rul… 

    …e should fail and when one index pattern does exist but another does not, the rule should succeed
    @dhurley14
    dhurley14 committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    e41de31 View commit details
    Browse the repository at this point in the history