chore(NA): support bazel and kbn packages in parallel on kbn pm and on distributable build scripts #89961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the final function
…o support both bazel and kbn packages
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
This comment has been minimized.
This comment has been minimized.
tylersmalley
reviewed
Feb 2, 2021
This comment has been minimized.
This comment has been minimized.
mistic
force-pushed
the
support-bazel-packages-on-kbn-pm
branch
from
1233850 to
6c4363c
Compare
This was referenced Feb 3, 2021
This comment has been minimized.
This comment has been minimized.
|
LGTM: verified by converting |
tylersmalley
approved these changes
Feb 4, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
7.x/7.12: 80b018e |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Feb 4, 2021
…n distributable build scripts (elastic#89961) * chore(NA): bazel projects support initial flag on kbn pm * chore(NA): every needed step to build production bazel packages except the final function * chore(NA): include build bazel production projects on kibana distributable build * chore(NA): support bazel packages when creating the package.json * chore(NA): including last changes on kbn pm and build distributable to support both bazel and kbn packages * chore(NA): missing annotation on build bazel packages * chore(NA): changed values on bazelrc common * chore(NA): fix bazel common rc * chore(NA): auto discovery if a kbn package is a Bazel package * chore(NA): last details to make bazel packages to built on distributable scripts * chore(NA): removed wrongly added line to x-pack package.json * chore(NA): apply correct formating * chore(NA): move into bazel bin * chore(NA): merge chnages on kbn pm * chore(NA): correctly setup ignore files for new bazel aggregated folder * chore(NA): merge with last master Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
tylersmalley
pushed a commit
that referenced
this pull request
Feb 4, 2021
…n distributable build scripts (#89961) (#90256) * chore(NA): bazel projects support initial flag on kbn pm * chore(NA): every needed step to build production bazel packages except the final function * chore(NA): include build bazel production projects on kibana distributable build * chore(NA): support bazel packages when creating the package.json * chore(NA): including last changes on kbn pm and build distributable to support both bazel and kbn packages * chore(NA): missing annotation on build bazel packages * chore(NA): changed values on bazelrc common * chore(NA): fix bazel common rc * chore(NA): auto discovery if a kbn package is a Bazel package * chore(NA): last details to make bazel packages to built on distributable scripts * chore(NA): removed wrongly added line to x-pack package.json * chore(NA): apply correct formating * chore(NA): move into bazel bin * chore(NA): merge chnages on kbn pm * chore(NA): correctly setup ignore files for new bazel aggregated folder * chore(NA): merge with last master Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
That PR enable us of actually starting developing the
BUILDfiles for Bazel packages.It enables an auto detector on
kbn-pmthat will classify packages as Bazel packages. It also introduces a couple of useful methods onkbn-pmso we can distinguish between bazelProjectsOnly and nonBazelProjects only.Finally it changes both the
kbn bootstrapand our distributable build scripts so we can have at the same time kbn and Bazel packages being built and consumed.