Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Migrates ML plugin to TS project ref #90021

Merged
merged 8 commits into from
Feb 3, 2021
Merged

[ML] Migrates ML plugin to TS project ref #90021

merged 8 commits into from
Feb 3, 2021

Conversation

peteharverson
Copy link
Contributor

Summary

Migrates the ML plugin to TS projects. Part of #80508.

Fixes #89270

@peteharverson peteharverson added review chore :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 2, 2021
@peteharverson peteharverson self-assigned this Feb 2, 2021
@peteharverson peteharverson requested a review from a team as a code owner February 2, 2021 15:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@weltenwort weltenwort mentioned this pull request Feb 2, 2021
Closed
15 tasks
@peteharverson
Copy link
Contributor Author

@elasticmachine merge upstream

walterra
walterra approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smith smith mentioned this pull request Feb 3, 2021
Merged
darnautov
darnautov approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@peteharverson peteharverson merged commit e108e5b into elastic:master Feb 3, 2021
@peteharverson peteharverson deleted the ml-ts-project-refs branch February 3, 2021 13:09
This was referenced Feb 3, 2021
Merged
Closed
peteharverson added a commit that referenced this pull request Feb 3, 2021
@peteharverson @kibanamachine
[ML] Migrates ML plugin to TS project ref (#90021) (#90162)
69f07c3 
* [ML] Migrate ML plugin to TS project ref

* [ML] Adding mocks folder to list of includes

* [ML] Remove duplicates from x-pack tsconfig.refs.json

* [ML] Add file_upload plugin to project references

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@walterra walterra walterra approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@peteharverson peteharverson

Labels
chore :ml release_note:skip Skip the PR/issue when compiling release notes review v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Migrate ML plugin to TS project references
5 participants
@peteharverson @elasticmachine @kibanamachine @walterra @darnautov