Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Remove extraneous period #90214

Merged
merged 3 commits into from
Feb 8, 2021
Merged

[Alerting] Remove extraneous period #90214

merged 3 commits into from
Feb 8, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Feb 3, 2021 •
edited
Loading

Resolves #89417

Summary

Removed extra period at the end of Only on status change option to be consistent with other options.
Screen Shot 2021-02-03 at 1 50 50 PM

@ymao1 ymao1 added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 labels Feb 3, 2021
@ymao1 ymao1 self-assigned this Feb 3, 2021
@ymao1 ymao1 requested a review from a team as a code owner February 3, 2021 18:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko
YulNaumenko approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Feb 4, 2021

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Feb 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB -1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris
gmmorris approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ymao1 ymao1 merged commit d804f4f into elastic:master Feb 8, 2021
@ymao1 ymao1 mentioned this pull request Feb 8, 2021
Merged
ymao1 added a commit to ymao1/kibana that referenced this pull request Feb 8, 2021
@ymao1 @kibanamachine
Remove extraneous period (elastic#90214)
d41a7cf 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ymao1 added a commit that referenced this pull request Feb 8, 2021
@ymao1 @kibanamachine
Remove extraneous period (#90214) (#90642)
c5ab5cf 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@ymao1 ymao1 deleted the alerting/remove-period branch March 25, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@gmmorris gmmorris gmmorris approved these changes

Assignees

@ymao1 ymao1

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor UI inconsistency
5 participants
@ymao1 @elasticmachine @kibanamachine @gmmorris @YulNaumenko