Use newfeed.service config for all newsfeeds

[gtback]

Summary

Prior to this change, the main kibana newsfeed would respect the
newsfeed.service.urlRoot config setting, but other feeds like
kibana-analytics would not. This made it difficult to test new feed
items using a local server.

Checklist

Delete any items that are not applicable to this PR.

• [?] Documentation was added for features that require explanation or tutorials
• [?] Unit or functional tests were updated or added to match the most common scenarios
• [NA, I think] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

I'm not sure if there's a place this should get documented, and I couldn't find any tests that cover this configuration; but I'm happy to add either if I need to. The config key itself isn't changing, it's just being used in more places.

I noticed there's a separate setting securitySolution:newsFeedUrl which is related, too.

For maintainers

• This was checked for breaking API changes and was labeled appropriately

CC: @dsmith001 @alexfrancoeur

[afharo]

Hey @gtback thank you for doing this change. I think they make perfect sense!

Re the tests, during functional tests, we point to a local Kibana:

kibana/test/common/config.js

Line 58 in f979580

`--newsfeed.service.urlRoot=${servers.kibana.protocol}://${servers.kibana.hostname}:${servers.kibana.port}`,

You might want to extend the test plugin to serve kibana-analytics to help with testing.

[Bamieh]

@elasticmachine merge upstream

[gtback]

Thanks @afharo!

You might want to extend the test plugin to serve kibana-analytics to help with testing.

If I understand this correctly, Kibana uses an internal test endpoint (/api/_newsfeed-FTS-external-service-simulators/) for running newsfeed service during tests. If anything, I'd consider refactoring the line below to parameterize the feed name (kibana). But I think this would be a more extensive refactoring, and for my use case I'm running a separate server locally with the newsfeed content.

`--newsfeed.service.pathTemplate=/api/_newsfeed-FTS-external-service-simulators/kibana/v{VERSION}.json`

If it's fine with you, I think I'll merge this once tests pass with the change you suggested above.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 98e3783

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
newsfeed	20.6KB	20.7KB	+23.0B

History

• 💚 Build #103778 succeeded dbb7585
• 💚 Build #103656 succeeded 773ec4e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[gtback]

@afharo is there anything I need to do to backport this, or does it happen automatically?

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 90252 or prevent reminders by adding the backport:skip label.