-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional tests - Add esSupertest support for SSL #90425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
test_infra
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.12.0
labels
Feb 5, 2021
@elasticmachine merge upstream |
dmlemeshko
reviewed
Feb 8, 2021
spalger
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…L is working" This reverts commit b525eed.
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/transform/feature_controls/transform_security·ts.transform feature controls security global all privileges (aka kibana_admin) should not render the "Stack" sectionStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Feb 9, 2021
This PR allows the functional test service esSupertest to work correctly in environments that have ES SSL enabled in the Kibana server configuration.
pheyos
added a commit
that referenced
this pull request
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows the functional test service
esSupertest
to work correctly in environments that have ES SSL enabled in the Kibana server configuration.Observed issue
functional_with_es_ssl
esSupertest
serviceInvestigated solutions
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
. But this is not working (process is terminated with a node warning about insecure HTTPS requests) and IMO also not the right way to fix it => we should rather tellsupertest
about the CAesSupertest
request, likeawait esSupertest.get(
/).ca(readFileSync(CA_CERT_PATH)).expect(200);
(with some some additional checking if SSL is enabled). While this is working, we would need to adjust all existing and future requests like this, which makes it unattractive => we should rather have it centrally in theesSupertest
servicesupertestAsPromised.agent
doesn't seem to support it:supertest
. So this is the solution I would prefer, but I'm also open to other suggestions.Notes for reviewers
esSupertest
in a deployment with ES SSL enabled.