Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabify] Add meta option to include top-level underscored field values #90535

Merged
merged 3 commits into from
Feb 9, 2021
Merged

[Tabify] Add meta option to include top-level underscored field values #90535

merged 3 commits into from
Feb 9, 2021

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Feb 5, 2021 •
edited
Loading

Summary

This PR adds an option to the TabifyDocsOptions interface that tells tabifyDocs to add the top-level "underscore" fields to the tabified data:

  • _id
  • _index
  • _type
  • _score

Discover allows a user to add these fields as columns, so tabifyDocs should know about them.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:AppServices v7.12.0 v7.13.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 5, 2021
@tsullivan tsullivan mentioned this pull request Feb 5, 2021
Merged
16 tasks
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan tsullivan marked this pull request as ready for review February 8, 2021 16:17
@tsullivan tsullivan requested a review from a team as a code owner February 8, 2021 16:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 797.7KB 797.9KB +182.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ppisljar
ppisljar approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@tsullivan tsullivan merged commit 4b3d1bf into elastic:master Feb 9, 2021
@tsullivan tsullivan deleted the tabify/allow-meta branch February 9, 2021 17:01
@tsullivan tsullivan mentioned this pull request Feb 9, 2021
Merged
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 9, 2021
@tsullivan @kibanamachine
[Tabify] Add meta option to include top-level underscored field values (
0fb7d22 
elastic#90535)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
tsullivan added a commit that referenced this pull request Feb 9, 2021
@tsullivan @kibanamachine
[Tabify] Add meta option to include top-level underscored field values (
fa8adf1 
#90535) (#90814)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsullivan @elasticmachine @kibanamachine @ppisljar