-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Time to Visualize] Clear All Editor State when Visualize Listing Page Loads #91005
[Time to Visualize] Clear All Editor State when Visualize Listing Page Loads #91005
Conversation
…to clear all editor state at once. Used that method in the visualize listing page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm jumping the gun here since this is in Draft mode, but I'm also not reviewing the code ;)
The fix works as expected. Thanks for the quick PR!
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Chrome and works as expected - by value flow still works fine, but after switching to Visualize list it's not connected to a dashboard anymore.
…e Loads (elastic#91005) * Changed the embeddable state transfer service so that it is possible to clear all editor state at once. Used that method in the visualize listing page
Summary
Followup to #89804
Fixes an issue where visiting the visualize listing page would not clear editor state for all apps. The new app-specific editor state is now fully cleared on load of the visualize listing page.
How to test:
Checklist
Delete any items that are not applicable to this PR.
For maintainers