Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time to Visualize] Clear All Editor State when Visualize Listing Page Loads #91005

Merged
merged 3 commits into from
Feb 12, 2021

Conversation

ThomThomson
Copy link
Contributor

Summary

Followup to #89804

Fixes an issue where visiting the visualize listing page would not clear editor state for all apps. The new app-specific editor state is now fully cleared on load of the visualize listing page.

How to test:

  1. From a dashboard, create a lens panel. Save and return
  2. Also create a maps panel from the dashboard, save and return
  3. Also create a visualize panel from the dashboard, save and return
  4. Navigate to the Visualize app. Ensure the listing page loads, not the last visualization you were on.
  5. Create a new Map, Lens, and Visualization from this page.
  6. Each editor should not be linked to the originating app.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

…to clear all editor state at once. Used that method in the visualize listing page
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Project:TimeToVisualize v7.12.0 labels Feb 10, 2021
@ryankeairns ryankeairns self-requested a review February 10, 2021 19:34
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm jumping the gun here since this is in Draft mode, but I'm also not reviewing the code ;)
The fix works as expected. Thanks for the quick PR!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualize 98.8KB 98.8KB -31.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 191.4KB 191.6KB +245.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review February 10, 2021 23:20
@ThomThomson ThomThomson requested a review from a team February 10, 2021 23:20
@ThomThomson ThomThomson requested a review from a team as a code owner February 10, 2021 23:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and works as expected - by value flow still works fine, but after switching to Visualize list it's not connected to a dashboard anymore.

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Feb 11, 2021
@ThomThomson ThomThomson merged commit 7994e87 into elastic:master Feb 12, 2021
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Feb 12, 2021
…e Loads (elastic#91005)

* Changed the embeddable state transfer service so that it is possible to clear all editor state at once. Used that method in the visualize listing page
ThomThomson added a commit that referenced this pull request Feb 12, 2021
…e Loads (#91005) (#91271)

* Changed the embeddable state transfer service so that it is possible to clear all editor state at once. Used that method in the visualize listing page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame Project:TimeToVisualize release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants