[Search Sessions] Enable Search Sessions #91097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Dosant
changed the title
Dosant
added
release highlight
Team:AppServices
v7.12.0
v8.0.0
Feature:Search
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
Dosant
requested review from
lizozom,
lukasolson,
tsullivan,
elastic-jb and
legrego
legrego
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Test changes LGTM - thank you for the ping on this PR, AND for the added functional tests in #90818!
Edit: I'd like to see the user filtering PR merged ahead of this one. We shouldn't turn this on by default until we have the per-user restrictions in place
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
lizozom
approved these changes
Feb 13, 2021
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Feb 13, 2021
* enable search sessions * adjust tests * adjust tests * adjust tests * adjust tests * make order consistent Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lizozom
added a commit
that referenced
this pull request
Feb 14, 2021
* [Search Sessions] Enable Search Sessions (#91097) * enable search sessions * adjust tests * adjust tests * adjust tests * adjust tests * make order consistent Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * adjust tests that is skipped in master and also needs adjustment in master to pass with search sessions Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
❗ Waiting for #84975 merged first
Enables Search Sessions by default
I had to tweak a bunch of feature_controls tests. In the most of the cases changed
global_dashboard_all->global_dashboard_read. Those tests are testing the visibility of specific management sections and assertions broke because as per #90818dashboard_allanddiscover_allnow enable search sessions and search session management becomes available.Release Notes
Search Sessions in Discover and Dashboard are available