Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Adding comparison latency chart #91339

Merged
merged 26 commits into from
Mar 10, 2021
Merged

[APM] Adding comparison latency chart #91339

merged 26 commits into from
Mar 10, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #90571

Screenshot 2021-02-08 at 11 07 12

comparison.latency.chart.mov

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 apm:comparison auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 13, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner February 13, 2021 20:02
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

dgieselaar
dgieselaar reviewed Feb 15, 2021
View reviewed changes
x-pack/plugins/apm/public/components/shared/charts/latency_chart/index.tsx Outdated
customTheme={comparisonChartTheme}
timeseries={[
...currentPeriod,
...(comparisonEnabled && previousPeriod ? [previousPeriod] : []),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we using this flag in other places when deciding to pass the data to the component? not saying we shouldn't, but it should be consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgieselaar yes, the comparisonEnabled will be used on all charts to pass or not the previousPeriod data to the chart component.

@cauemarcondes cauemarcondes added v7.13.0 and removed v7.12.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 16, 2021
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@ogupte
Copy link
Contributor

ogupte commented Mar 8, 2021

I want to be able to compare today's latency data with yesterday, but when i select last 24 hrs, the comparison only allows you to select 'week before'. I feel like it should also let you select 'day before' but this only is avaible if it's > 24 hrs.
Screen Shot 2021-03-08 at 1 13 29 PM

@ogupte
Copy link
Contributor

ogupte commented Mar 8, 2021

Weird issue that might be from the charts...when i move the mouse cursor from the data the annotation, it will not display the tooltip for the annotation, but if i move my mouse out of the chart then back in on the annotation from the top, then it does display the tooltip:

comparizons-latency-0

@cauemarcondes
Copy link
Contributor Author

cauemarcondes commented Mar 8, 2021 •
edited
Loading

I want to be able to compare today's latency data with yesterday, but when i select last 24 hrs, the comparison only allows you to select 'week before'. I feel like it should also let you select 'day before' but this only is avaible if it's > 24 hrs.

Thanks @ogupte, it was fixed here 648f0f4

Screen Shot 2021-03-08 at 14 07 33

Screen Shot 2021-03-08 at 14 07 23

@cauemarcondes
Copy link
Contributor Author

cauemarcondes commented Mar 8, 2021 •
edited
Loading

Weird issue that might be from the charts...when i move the mouse cursor from the data the annotation, it will not display the tooltip for the annotation, but if i move my mouse out of the chart then back in on the annotation from the top, then it does display the tooltip:

@ogupte I asked the charts team.

New bug opened: elastic/elastic-charts#1063

ogupte
ogupte approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, but it looks good!

@cauemarcondes cauemarcondes mentioned this pull request Mar 8, 2021
Closed
@cauemarcondes
Copy link
Contributor Author

jenkins, retest this please

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.3MB 5.3MB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit f428b10 into elastic:master Mar 10, 2021
@cauemarcondes cauemarcondes deleted the apm-time-comparison-latency-chart branch March 10, 2021 16:02
@cauemarcondes cauemarcondes mentioned this pull request Mar 10, 2021
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Mar 10, 2021
@cauemarcondes @kibanamachine
[APM] Adding comparison latency chart (elastic#91339)
d203585 
* adding time comparison to latency chart

* adding time comparison to latency chart

* fixing TS

* fixing api test

* addressing PR comments

* adding api test

* addressing PR comments

* fixing api test

* rounding date diff

* addressing PR comments

* fixing api test

* refactoring

* fixing ts issue

* fixing offset function

* fixing offset function

* addressing PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cauemarcondes added a commit that referenced this pull request Mar 10, 2021
@cauemarcondes @kibanamachine
[APM] Adding comparison latency chart (#91339) (#94320)
773c11c 
* adding time comparison to latency chart

* adding time comparison to latency chart

* fixing TS

* fixing api test

* addressing PR comments

* adding api test

* addressing PR comments

* fixing api test

* rounding date diff

* addressing PR comments

* fixing api test

* refactoring

* fixing ts issue

* fixing offset function

* fixing offset function

* addressing PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@cauemarcondes cauemarcondes mentioned this pull request Apr 21, 2021
Closed
@ogupte ogupte self-assigned this May 10, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv left review comments

@ogupte ogupte ogupte approved these changes

@dgieselaar dgieselaar Awaiting requested review from dgieselaar

Assignees

@ogupte ogupte

Labels
apm:comparison apm:test-plan-7.13.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Adding comparison latency chart
6 participants
@cauemarcondes @elasticmachine @ogupte @kibanamachine @sorenlouv @dgieselaar