-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Fix index pattern switch behavior #92131
[Discover] Fix index pattern switch behavior #92131
Conversation
@elasticmachine merge upstream |
…' of github.com:kertal/kibana into kertal-pr-2021-02-22-discover-fix-index-switch-behavior
…-22-discover-fix-index-switch-behavior
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this in Chrome on Mac OS and works as expected. Code changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the scenarios I could think of and it works well.
Summary
This PR takes care of an issue introduced in #92132 when you switch index patterns, found while testing for #88426
_source
as default column when switching index patterns. This is now handled in state managementTesting
kibana_sample_data_ecommerce
demo datakibana_sample_data-eco*
, without time fieldkibana_sample_data-eco*
sort
part of the URL, it should be empty. Before it was containingorder_date,desc
. So it was still sorted, but you had to add theorder_date
column to change this (Or edit the URL) ... confusingFurthermore
timeFieldA
totimeFieldB
(e.g. fromkibana_sample_data_ecommerce
tokibana_sample_data_flights
)timeFieldB
Checklist