[Alerting] Fixing Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts - alerting api integration security and spaces enabled Alerts legacy alerts alerts superuser at space1 should schedule actions on legacy alerts #92549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-test-legacy-alert
…-test-legacy-alert
…-test-legacy-alert
…-test-legacy-alert
…-test-legacy-alert
…-test-legacy-alert
…-test-legacy-alert
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
ymao1
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
mikecote
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Code LGTM! We'll be able to remove these legacy tests with https://github.com/elastic/kibana/issues/90386 relatively soon :-)
ymao1
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2021
….x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts - alerting api integration security and spaces enabled Alerts legacy alerts alerts superuser at space1 should schedule actions on legacy alerts (elastic#92549) * Unskipping test * Increasing runAt time * Increasing runAt time * Logging * Increasing wait time even more * Removing logs * Resetting task status * Re-enabling all tests * Re-enabling all tests * Adding comment
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2021
….x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts - alerting api integration security and spaces enabled Alerts legacy alerts alerts superuser at space1 should schedule actions on legacy alerts (#92549) (#92690) * Unskipping test * Increasing runAt time * Increasing runAt time * Logging * Increasing wait time even more * Removing logs * Resetting task status * Re-enabling all tests * Re-enabling all tests * Adding comment Co-authored-by: ymao1 <ying.mao@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #86952
Summary
This test was flaky due to a race condition when loading legacy alerts and task manager tasks from es archiver and migrating them. When the task manager tasks have finished migrating, task manager starts running them right away. If the kibana index was mid-migration, the task manager would try to look up an alert and get this error
Saved object index alias [.kibana_8.0.0] not found: index_not_found_exception. This error would cause the task to set status tofailedand not try to rerun the alert, which means downstream tests that depend on the alert executing would then fail.I am mitigating this issue by resetting the task status to
idle, meaning the task manager would be able to continue picking up this task.Verified with Rudolph that this is a limitation of the functional tests and this should not happen in Kibana since task manager does not start polling until after all plugin setup (when migrations are run) are complete.
Successful flaky test runs:
Checklist
Delete any items that are not applicable to this PR.