Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add functional tests for runtime mappings in Transforms #92738

Merged
merged 13 commits into from
Mar 9, 2021
Merged

[ML] Add functional tests for runtime mappings in Transforms #92738

merged 13 commits into from
Mar 9, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Feb 24, 2021 •
edited
Loading

Summary

Part of #88811. This PR adds functional tests for Transform runtime mappings editor during cloning and creation. It validates:

  • The runtime mappings editor is showing the runtime config correctly
  • The index data preview is showing the runtime fields correctly (the cells should not be empty)
  • The group by/aggregation should have the runtime fields
  • The Transform preview is showing correctly (the cells should not be empty for Pivot)
  • The index pattern is created with the runtime mappings defined

Checklist

@qn895 qn895 self-assigned this Feb 24, 2021
@qn895 qn895 mentioned this pull request Feb 24, 2021
Closed
9 tasks
@qn895 qn895 marked this pull request as ready for review February 25, 2021 14:56
@qn895 qn895 requested a review from a team as a code owner February 25, 2021 14:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895 qn895 added the release_note:skip Skip the PR/issue when compiling release notes label Feb 25, 2021
pheyos
pheyos approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Just one small suggestion.

x-pack/test/functional/services/transform/wizard.ts Outdated Show resolved Hide resolved
@qn895
Copy link
Member Author

qn895 commented Mar 1, 2021 •
edited
Loading

Started flaky test suite runner... Successful after 42 runs ✅

@qn895
Copy link
Member Author

qn895 commented Mar 8, 2021

@elasticmachine merge upstream

@qn895 qn895 requested a review from darnautov March 8, 2021 15:23
@qn895 qn895 added v7.13.0 and removed v7.12.0 labels Mar 8, 2021
darnautov
darnautov approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x-pack/test/functional/apps/transform/creation_runtime_mappings.ts Outdated
await transform.testExecution.logTestStep('redirects to Discover page');
await transform.wizard.redirectToDiscover();

if (testData.type === 'latest') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (testData.type === 'latest') {
if (isLatestTransformTestData(testData)) {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here 24bb5d1

peteharverson
peteharverson approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson mentioned this pull request Mar 9, 2021
Closed
15 tasks
@qn895
Copy link
Member Author

qn895 commented Mar 9, 2021 •
edited
Loading

Started flaky test suite runner... Successful after 42 runs ✅

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.4MB 6.4MB -1.0B
transform 946.1KB 946.2KB +65.0B
total +64.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 9, 2021
@qn895 qn895 merged commit fcf397f into elastic:master Mar 9, 2021
@qn895 qn895 deleted the ml-transform-runtime-tests branch March 9, 2021 17:26
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 9, 2021
@qn895 @kibanamachine
[ML] Add functional tests for runtime mappings in Transforms (elastic…
361c21a 
…#92738)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 9, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #94155

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 9, 2021
@kibanamachine @qn895
[ML] Add functional tests for runtime mappings in Transforms (#92738) (…
d5ce8f1 
…#94155)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

@pheyos pheyos pheyos approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@qn895 qn895

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qn895 @elasticmachine @kibanamachine @pheyos @darnautov @peteharverson