Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ml] migrate file_data_visualizer/analyze_file to file_upload plugin #94259

Merged
merged 5 commits into from
Mar 20, 2021
Merged

[ml] migrate file_data_visualizer/analyze_file to file_upload plugin #94259

merged 5 commits into from
Mar 20, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 10, 2021 •
edited
Loading

PR migrates file_data_visualizer/analyze_file route from ml plugin to file_upload plugin. PR moves required typings.

@nreese nreese added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:File Upload v7.13.0 labels Mar 10, 2021
@nreese nreese requested a review from a team as a code owner March 10, 2021 04:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@nreese
Copy link
Contributor Author

nreese commented Mar 10, 2021

@elasticmachine merge upstream

jgowdyelastic
jgowdyelastic approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@nreese
Copy link
Contributor Author

nreese commented Mar 20, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB +43.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit a6c0ff6 into elastic:master Mar 20, 2021
nreese added a commit to nreese/kibana that referenced this pull request Mar 20, 2021
@nreese @kibanamachine
[ml] migrate file_data_visualizer/analyze_file to file_upload plugin (e…
75476d7 
…lastic#94259)

* [ml] migrate file_data_visualizer/analyze_file to file_upload plugin

* tslint

* give analyze route access to ml user

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@nreese nreese mentioned this pull request Mar 20, 2021
Merged
nreese added a commit that referenced this pull request Mar 20, 2021
@nreese @kibanamachine
[ml] migrate file_data_visualizer/analyze_file to file_upload plugin (#…
c0c6272 
…94259) (#95022)

* [ml] migrate file_data_visualizer/analyze_file to file_upload plugin

* tslint

* give analyze route access to ml user

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@qn895 qn895 mentioned this pull request Jun 4, 2021
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees
No one assigned
Labels
Feature:File Upload :ml release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @jgowdyelastic