chore(NA): moving @elastic/datemath into bazel #94665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…temath-into-bazel
…temath-into-bazel
mistic
added
chore
v8.0.0
release_note:skip
tylersmalley
approved these changes
Mar 16, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mistic
force-pushed
the
moving-elastic-datemath-into-bazel
branch
from
b325a6f to
d5ee22d
Compare
This comment has been minimized.
This comment has been minimized.
mistic
force-pushed
the
moving-elastic-datemath-into-bazel
branch
from
f69487a to
8e40699
Compare
mistic
added
the
auto-backport
This comment has been minimized.
This comment has been minimized.
…c/kibana into moving-elastic-datemath-into-bazel
tylersmalley
reviewed
Apr 1, 2021
| @@ -98,7 +98,7 @@ | |||
| "@elastic/apm-rum": "^5.6.1", | |||
| "@elastic/apm-rum-react": "^1.2.5", | |||
| "@elastic/charts": "26.1.0", | |||
| "@elastic/datemath": "link:packages/elastic-datemath", | |||
| "@elastic/datemath": "link:bazel-bin/packages/elastic-datemath/npm_module", | |||
There was a problem hiding this comment.
👍 I like this better than the build target name.
tylersmalley
approved these changes
Apr 1, 2021
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 Backport failed❌ 7.x: Commit could not be cherrypicked due to conflicts To backport manually run: |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Apr 1, 2021
* chore(NA): majority of the changes needed to build elastic-datemath with bazel * chore(NA): add missing bits on elastic-datemath package * chore(NA): add missing build and watch scripts * chore(NA): remove build scripts for elastic datemah * chore(NA): remove typo from build baze production projects logs * chore(NA): force install on CI * chore(NA): introduce custom preserve symlinks resolver for jest * chore(NA): update jest integration snapshot * chore(NA): fix build for bazel packages * chore(NA): correctly copy bazel built packages into final distributable build * chore(NA): update kbn pm dist * chore(NA): experimental new logic to handle bazel yarn rule rerun using yarn-integrity file * chore(NA): update snapshots * refact(NA): ensure yarn integrity exists into two methods * chore(NA): fix ts error * chore(NA): update snapshots * chore(NA): update elastic-datemath build file to include ts_project rule * chore(NA): update basic optimization test snapshots * chore(NA): merge and solve conflicts cherry-pick from elastic#96066 * chore(NA): update package.json and yarn.lock file * chore(NA): update bazel/bin into bazel-bin on kbn-pm build bazel packages Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # package.json
mistic
added a commit
that referenced
this pull request
Apr 2, 2021
* chore(NA): majority of the changes needed to build elastic-datemath with bazel * chore(NA): add missing bits on elastic-datemath package * chore(NA): add missing build and watch scripts * chore(NA): remove build scripts for elastic datemah * chore(NA): remove typo from build baze production projects logs * chore(NA): force install on CI * chore(NA): introduce custom preserve symlinks resolver for jest * chore(NA): update jest integration snapshot * chore(NA): fix build for bazel packages * chore(NA): correctly copy bazel built packages into final distributable build * chore(NA): update kbn pm dist * chore(NA): experimental new logic to handle bazel yarn rule rerun using yarn-integrity file * chore(NA): update snapshots * refact(NA): ensure yarn integrity exists into two methods * chore(NA): fix ts error * chore(NA): update snapshots * chore(NA): update elastic-datemath build file to include ts_project rule * chore(NA): update basic optimization test snapshots * chore(NA): merge and solve conflicts cherry-pick from #96066 * chore(NA): update package.json and yarn.lock file * chore(NA): update bazel/bin into bazel-bin on kbn-pm build bazel packages Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # package.json
|
7.x/7.13: b47ab19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
That PR moves the
@elastic/datemathinto Bazel by pushing a BUILD file for that package.After merging this the package will be consumed from within
bazel/binfolder.