[Monitoring] Bulk Uploader uses new ES client #94908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
release_note:skip
afharo
force-pushed
the
monitoring/bulk_uploader/use-default-client
branch
from
ec908b8 to
353ee37
Compare
igoristic
approved these changes
Mar 18, 2021
mshustov
approved these changes
Mar 21, 2021
joshdover
approved these changes
Mar 22, 2021
|
@elasticmachine merge upstream |
Bamieh
approved these changes
Mar 22, 2021
|
@elasticmachine merge upstream |
afharo
added
the
auto-backport
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 23, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 23, 2021
afharo
added a commit
to afharo/kibana
that referenced
this pull request
Mar 23, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/monitoring/server/plugin.test.ts # x-pack/plugins/monitoring/server/plugin.ts # x-pack/plugins/monitoring/server/types.ts
afharo
added a commit
that referenced
this pull request
Mar 23, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/monitoring/server/plugin.test.ts # x-pack/plugins/monitoring/server/plugin.ts # x-pack/plugins/monitoring/server/types.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #94900.
Bulk Uploader uses an Elasticsearch client that connects to its own cluster (not the remote one). It used to extend the legacy client to provide support to the
monitoring.bulkrequests. Maintaining its own client required handling reconnections.The new client provides that for free. This PR updates the Bulk Uploader to use the new client instead.
Checklist
Delete any items that are not applicable to this PR.
For maintainers