-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unskipping functional tests to check their flakiness #95349
unskipping functional tests to check their flakiness #95349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Good to see that skipped tests are checked for flakiness! My two items:
- Left a comment on the ML test, see below.
- A general note: many
.skip
's are accompanied by a code comment pointing to an issue. If the.skip
is removed, I think the corresponding issue should be closed (linking to this fix PR) and the comment should be removed.
// FLAKY: https://github.com/elastic/kibana/issues/93188 | ||
describe.skip('total feature importance panel and decision path popover', function () { | ||
describe('total feature importance panel and decision path popover', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can see from the issues linked in the comment, this has just recently been skipped and we're investigating how to stabilize it. It's failing rather rarely but it's definitely flaky, so chances are that it would pass your PR checks but fail later after re-activation. Please don't remove this skip
for now.
@elasticmachine merge upstream |
merge conflict between base and head |
…onal_tests_master
@elasticmachine merge upstream |
I'm going to mark this as draft until the PR is ready to review |
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/visualize/_add_to_dashboard·ts.visualize app Add to Dashboard adding a new metric to an existing dashboard by valueStandard Out
Stack Trace
Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/url_field_formatter·ts.dashboard app using current data Changing field formatter to Url "before all" hook for "applied on dashboard"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/url_field_formatter·ts.dashboard app using current data Changing field formatter to Url "before all" hook for "applied on dashboard"Standard Out
Stack Trace
and 10 more failures, only showing the first 3. Metrics [docs]
History
To update your PR or re-run it, just comment with: |
similar effort: #110310 |
closing this PR in lieu of: #110310 |
....from Kibana and x-pack dir
Notes: Used a
sed
command to find and replace.skip
tests.grep -r ".skip(" test/functional/apps/* -B 1 — master
cd into test/functional/apps/
for i in `find ./ -type f`; do sed -i.bu "s|\.skip(|(|g" $i; done
--- bu - backup , s - substitute , .skip( - replace with just (|
Repeat for x-pack test/functional/apps
to check:
git diff --cached