chore(NA): enable preserve symlinks for ts without breaking packages development #95433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymlinks-for-ts-without-breaking-packages
mistic
force-pushed
the
enable-preserve-symlinks-for-ts-without-breaking-packages
branch
from
9f12499 to
1c3fcc9
Compare
…ymlinks-for-ts-without-breaking-packages
…upstream - refactored
spalger
reviewed
Mar 26, 2021
mistic
force-pushed
the
enable-preserve-symlinks-for-ts-without-breaking-packages
branch
2 times, most recently
from
7a56b6c to
9268491
Compare
…sources on kbn-test package
…ymlinks-for-ts-without-breaking-packages
|
Thanks @spalger for the help you gave here to overcome the type clashes on |
mistic
added
auto-backport
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
It works for me now! I think I know what the issue is but it's unrelated. Opening up another PR |
tylersmalley
approved these changes
Mar 30, 2021
|
I don't want to block this PR on all the codeowners reviews triggered by this change. If anyone has any issues with it, we can address but we're mostly responsible for the files changed here. @spalger if you sign off I suggest we go ahead and merge. |
vigneshshanmugam
approved these changes
Mar 30, 2021
jportner
approved these changes
Mar 30, 2021
…ymlinks-for-ts-without-breaking-packages
…d kbn-telemetry-tools
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
Unknown metric groups@kbn/ui-shared-deps asset size
History
To update your PR or re-run it, just comment with: |
mistic
added
auto-backport
💔 Backport failed❌ 7.x: Commit could not be cherrypicked due to conflicts To backport manually run: |
1 similar comment
💔 Backport failed❌ 7.x: Commit could not be cherrypicked due to conflicts To backport manually run: |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Mar 31, 2021
…development (elastic#95433) * chore(NA): move elastic-datemath into a ts package * chore(NA): finish elastic-datemath * chore(NA): finish elastic-datemath * chore(NA): source folder for elastic-datemath * chore(NA): add source-maps ace, analytics, apm-config-loader and apm-utils packages * chore(NA): add sourcemaps to packages on typescript * chore(NA): move test fixtures within source * chore(NA): correct exclusions on packages * chore(NA): correct package.json on all packages * chore(NA): correct package.json on all packages * chore(NA): complete kbn pm * chore(NA): default export on elastic-datemath * chore(NA): include logs on kbn-logging * chore(NA): update bundle ref module to last code used in the webpack upstream * chore(NA): update bundle ref module to last code used in the webpack upstream - refactored * chore(NA): remove override method for exportsArgument * fix(NA): typechecking problems by use @internal at javascript import sources on kbn-test package * fix(NA): typescript projects check * fix(NA): run optimizer integration tests from source * chore(NA): fix usage from target for kbn optimizer * chore(NA): path on tsconfig * chore(NA): move tsignore into ts-expect-error * chore(NA): include souce maps on kbn cli dev * chore(NA): include souce maps on kbn-crypto, kbn-server-http-tools and kbn-telemetry-tools * chore(NA): add issue links into the ts-expect-error comments # Conflicts: # packages/elastic-datemath/README.md # packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts
mistic
added a commit
that referenced
this pull request
Mar 31, 2021
…development (#95433) (#95884) * chore(NA): move elastic-datemath into a ts package * chore(NA): finish elastic-datemath * chore(NA): finish elastic-datemath * chore(NA): source folder for elastic-datemath * chore(NA): add source-maps ace, analytics, apm-config-loader and apm-utils packages * chore(NA): add sourcemaps to packages on typescript * chore(NA): move test fixtures within source * chore(NA): correct exclusions on packages * chore(NA): correct package.json on all packages * chore(NA): correct package.json on all packages * chore(NA): complete kbn pm * chore(NA): default export on elastic-datemath * chore(NA): include logs on kbn-logging * chore(NA): update bundle ref module to last code used in the webpack upstream * chore(NA): update bundle ref module to last code used in the webpack upstream - refactored * chore(NA): remove override method for exportsArgument * fix(NA): typechecking problems by use @internal at javascript import sources on kbn-test package * fix(NA): typescript projects check * fix(NA): run optimizer integration tests from source * chore(NA): fix usage from target for kbn optimizer * chore(NA): path on tsconfig * chore(NA): move tsignore into ts-expect-error * chore(NA): include souce maps on kbn cli dev * chore(NA): include souce maps on kbn-crypto, kbn-server-http-tools and kbn-telemetry-tools * chore(NA): add issue links into the ts-expect-error comments # Conflicts: # packages/elastic-datemath/README.md # packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
We need to enable the
preserveSymlinksoption on the typescript config in order to support the consumption from packages built by bazel. However we discovered that broke the development of packages built in typescript as we were no longer able to click and follow requires into the source. By built the sourcemaps and correctly configuresourceRootwe were able to fix the behaviour. I've also applied the same standards into all typescript packages.Some packages were left out of this work because they are not being required often and a migration into typescript was needed, or because they do not change frequently. Those are: