Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTI] Filters alerts table by presence of threat (elastic/security-team#907) #96096

Merged
merged 12 commits into from
Apr 12, 2021
Merged

[CTI] Filters alerts table by presence of threat (elastic/security-team#907) #96096

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
077ac2a
[CTI] Filters alerts table by presence of threat (elastic/security-te…
ecezalp Apr 1, 2021
66be4d2
fixes type error, updates meta values of filters
ecezalp Apr 5, 2021
f997f01
Merge branch 'master' into threat-filter
kibanamachine Apr 5, 2021
20c3466
Reverts change to buildAlertsRuleIdFilter, and combines the threat …
ecezalp Apr 6, 2021
0ac8f87
Adds ts-ignore to default_config.test.ts
ecezalp Apr 6, 2021
8a63480
Merge branch 'master' into threat-filter
kibanamachine Apr 6, 2021
6052993
updates AdditionalFilterContent gutter size and message
ecezalp Apr 7, 2021
1d3b581
Merge branch 'master' into threat-filter
kibanamachine Apr 7, 2021
a956112
Merge branch 'master' into threat-filter
kibanamachine Apr 7, 2021
cce193f
fixes reverted buildShowBuildingBlockFilter logic
ecezalp Apr 12, 2021
945101b
Merge branch 'master' into threat-filter
kibanamachine Apr 12, 2021
5ae850c
rename commit
ecezalp Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
271 changes: 235 additions & 36 deletions ...rity_solution/public/detections/components/alerts_table/alerts_utility_bar/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,19 @@ describe('AlertsUtilityBar', () => {
test('renders correctly', () => {
const wrapper = shallow(
<AlertsUtilityBar
hasIndexWrite={true}
hasIndexMaintenance={true}
areEventsLoading={false}
clearSelection={jest.fn()}
totalCount={100}
selectedEventIds={{}}
currentFilter="closed"
hasIndexMaintenance={true}
rylnd marked this conversation as resolved.
Show resolved Hide resolved
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={jest.fn()}
onShowThreatMatchesOnlyChanged={jest.fn()}
selectAll={jest.fn()}
showClearSelection={true}
selectedEventIds={{}}
showBuildingBlockAlerts={false}
onShowBuildingBlockAlertsChanged={jest.fn()}
showClearSelection={true}
showThreatMatchesOnly={false}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
);
Expand All @@ -41,17 +43,19 @@ describe('AlertsUtilityBar', () => {
const wrapper = mount(
<TestProviders>
<AlertsUtilityBar
hasIndexWrite={true}
hasIndexMaintenance={true}
areEventsLoading={false}
clearSelection={jest.fn()}
totalCount={100}
selectedEventIds={{}}
currentFilter="closed"
hasIndexMaintenance={true}
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={onShowBuildingBlockAlertsChanged}
onShowThreatMatchesOnlyChanged={jest.fn()}
selectAll={jest.fn()}
showClearSelection={true}
selectedEventIds={{}}
showBuildingBlockAlerts={false} // Does not show showBuildingBlockAlerts checked if this is false
onShowBuildingBlockAlertsChanged={onShowBuildingBlockAlertsChanged}
showClearSelection={true}
showThreatMatchesOnly={false}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
</TestProviders>
Expand All @@ -72,22 +76,61 @@ describe('AlertsUtilityBar', () => {
).toEqual(false);
});

test('does not show the showThreatMatchesOnly checked if the showThreatMatchOnly is false', () => {
const wrapper = mount(
<TestProviders>
<AlertsUtilityBar
areEventsLoading={false}
clearSelection={jest.fn()}
currentFilter="closed"
hasIndexMaintenance={true}
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={jest.fn()}
onShowThreatMatchesOnlyChanged={jest.fn()}
selectAll={jest.fn()}
selectedEventIds={{}}
showBuildingBlockAlerts={false} // Does not show showBuildingBlockAlerts checked if this is false
showClearSelection={true}
showThreatMatchesOnly={false}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
</TestProviders>
);
// click the filters button to popup the checkbox to make it visible
wrapper
.find('[data-test-subj="additionalFilters"] button')
.first()
.simulate('click')
.update();

// The check box should be false
expect(
wrapper
.find('[data-test-subj="showThreatMatchesOnlyCheckbox"] input')
.first()
.prop('checked')
).toEqual(false);
});

test('does show the showBuildingBlockAlerts checked if the showBuildingBlockAlerts is true', () => {
const onShowBuildingBlockAlertsChanged = jest.fn();
const wrapper = mount(
<TestProviders>
<AlertsUtilityBar
hasIndexWrite={true}
hasIndexMaintenance={true}
areEventsLoading={false}
clearSelection={jest.fn()}
totalCount={100}
selectedEventIds={{}}
currentFilter="closed"
hasIndexMaintenance={true}
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={onShowBuildingBlockAlertsChanged}
onShowThreatMatchesOnlyChanged={jest.fn()}
selectAll={jest.fn()}
showClearSelection={true}
selectedEventIds={{}}
showBuildingBlockAlerts={true} // Does show showBuildingBlockAlerts checked if this is true
onShowBuildingBlockAlertsChanged={onShowBuildingBlockAlertsChanged}
showClearSelection={true}
showThreatMatchesOnly={false}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
</TestProviders>
Expand All @@ -108,22 +151,61 @@ describe('AlertsUtilityBar', () => {
).toEqual(true);
});

test('does show the showThreatMatchesOnly checked if the showThreatMatchesOnly is true', () => {
const wrapper = mount(
<TestProviders>
<AlertsUtilityBar
areEventsLoading={false}
clearSelection={jest.fn()}
currentFilter="closed"
hasIndexMaintenance={true}
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={jest.fn()}
onShowThreatMatchesOnlyChanged={jest.fn()}
selectAll={jest.fn()}
selectedEventIds={{}}
showBuildingBlockAlerts={true} // Does show showBuildingBlockAlerts checked if this is true
showClearSelection={true}
showThreatMatchesOnly={true}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
</TestProviders>
);
// click the filters button to popup the checkbox to make it visible
wrapper
.find('[data-test-subj="additionalFilters"] button')
.first()
.simulate('click')
.update();

// The check box should be true
expect(
wrapper
.find('[data-test-subj="showThreatMatchesOnlyCheckbox"] input')
.first()
.prop('checked')
).toEqual(true);
});

test('calls the onShowBuildingBlockAlertsChanged when the check box is clicked', () => {
const onShowBuildingBlockAlertsChanged = jest.fn();
const wrapper = mount(
<TestProviders>
<AlertsUtilityBar
hasIndexWrite={true}
hasIndexMaintenance={true}
areEventsLoading={false}
clearSelection={jest.fn()}
totalCount={100}
selectedEventIds={{}}
currentFilter="closed"
hasIndexMaintenance={true}
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={onShowBuildingBlockAlertsChanged}
onShowThreatMatchesOnlyChanged={jest.fn()}
selectAll={jest.fn()}
showClearSelection={true}
selectedEventIds={{}}
showBuildingBlockAlerts={false}
onShowBuildingBlockAlertsChanged={onShowBuildingBlockAlertsChanged}
showClearSelection={true}
showThreatMatchesOnly={false}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
</TestProviders>
Expand All @@ -145,39 +227,82 @@ describe('AlertsUtilityBar', () => {
expect(onShowBuildingBlockAlertsChanged).toHaveBeenCalled();
});

test('calls the onShowThreatMatchesOnlyChanged when the check box is clicked', () => {
const onShowThreatMatchesOnlyChanged = jest.fn();
const wrapper = mount(
<TestProviders>
<AlertsUtilityBar
areEventsLoading={false}
clearSelection={jest.fn()}
currentFilter="closed"
hasIndexMaintenance={true}
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={jest.fn()}
onShowThreatMatchesOnlyChanged={onShowThreatMatchesOnlyChanged}
selectAll={jest.fn()}
selectedEventIds={{}}
showBuildingBlockAlerts={false}
showClearSelection={true}
showThreatMatchesOnly={false}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
</TestProviders>
);
// click the filters button to popup the checkbox to make it visible
wrapper
.find('[data-test-subj="additionalFilters"] button')
.first()
.simulate('click')
.update();

// check the box
wrapper
.find('[data-test-subj="showThreatMatchesOnlyCheckbox"] input')
.first()
.simulate('change', { target: { checked: true } });

// Make sure our callback is called
expect(onShowThreatMatchesOnlyChanged).toHaveBeenCalled();
});

test('can update showBuildingBlockAlerts from false to true', () => {
const Proxy = (props: AlertsUtilityBarProps) => (
<TestProviders>
<AlertsUtilityBar
hasIndexWrite={true}
hasIndexMaintenance={true}
areEventsLoading={false}
clearSelection={jest.fn()}
totalCount={100}
selectedEventIds={{}}
currentFilter="closed"
hasIndexMaintenance={true}
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={jest.fn()}
onShowThreatMatchesOnlyChanged={jest.fn()}
selectAll={jest.fn()}
showClearSelection={true}
selectedEventIds={{}}
showBuildingBlockAlerts={props.showBuildingBlockAlerts}
onShowBuildingBlockAlertsChanged={jest.fn()}
showClearSelection={true}
showThreatMatchesOnly={false}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
</TestProviders>
);

const wrapper = mount(
<Proxy
hasIndexWrite={true}
hasIndexMaintenance={true}
areEventsLoading={false}
clearSelection={jest.fn()}
totalCount={100}
selectedEventIds={{}}
currentFilter="closed"
hasIndexMaintenance={true}
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={jest.fn()}
onShowThreatMatchesOnlyChanged={jest.fn()}
selectAll={jest.fn()}
showClearSelection={true}
selectedEventIds={{}}
showBuildingBlockAlerts={false}
onShowBuildingBlockAlertsChanged={jest.fn()}
showClearSelection={true}
showThreatMatchesOnly={false}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
);
Expand Down Expand Up @@ -214,5 +339,79 @@ describe('AlertsUtilityBar', () => {
.prop('checked')
).toEqual(true);
});

test('can update showThreatMatchesOnly from false to true', () => {
const Proxy = (props: AlertsUtilityBarProps) => (
<TestProviders>
<AlertsUtilityBar
areEventsLoading={false}
clearSelection={jest.fn()}
currentFilter="closed"
hasIndexMaintenance={true}
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={jest.fn()}
onShowThreatMatchesOnlyChanged={jest.fn()}
selectAll={jest.fn()}
selectedEventIds={{}}
showBuildingBlockAlerts={false}
showClearSelection={true}
showThreatMatchesOnly={props.showThreatMatchesOnly}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
</TestProviders>
);

const wrapper = mount(
<Proxy
areEventsLoading={false}
clearSelection={jest.fn()}
currentFilter="closed"
hasIndexMaintenance={true}
hasIndexWrite={true}
onShowBuildingBlockAlertsChanged={jest.fn()}
onShowThreatMatchesOnlyChanged={jest.fn()}
selectAll={jest.fn()}
selectedEventIds={{}}
showBuildingBlockAlerts={false}
showClearSelection={true}
showThreatMatchesOnly={false}
totalCount={100}
updateAlertsStatus={jest.fn()}
/>
);
// click the filters button to popup the checkbox to make it visible
wrapper
.find('[data-test-subj="additionalFilters"] button')
.first()
.simulate('click')
.update();

// The check box should false now since we initially set the showBuildingBlockAlerts to false
expect(
wrapper
.find('[data-test-subj="showThreatMatchesOnlyCheckbox"] input')
.first()
.prop('checked')
).toEqual(false);

wrapper.setProps({ showThreatMatchesOnly: true });
wrapper.update();

// click the filters button to popup the checkbox to make it visible
wrapper
.find('[data-test-subj="additionalFilters"] button')
.first()
.simulate('click')
.update();

// The check box should be true now since we changed the showBuildingBlockAlerts from false to true
expect(
wrapper
.find('[data-test-subj="showThreatMatchesOnlyCheckbox"] input')
.first()
.prop('checked')
).toEqual(true);
});
});
});
Loading