-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Artifacts] Artifact creation for Endpoint Event Filtering #96499
[Security Solution][Artifacts] Artifact creation for Endpoint Event Filtering #96499
Conversation
…t-filter-artifacts
…t-filter-artifacts
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!!
Thanks @madirey FYI: I might open up an issue to do some refactoring to manifest manger so that we don't have so much code duplication whenever we want to add a new artifact that is based upon the Exceptions lists. We should be able to just define the new type (ex. array of artifacts) and then have it use the same logic to loop through them. |
…iltering (elastic#96499) * generate endpoint event filters artifacts * Add ExperimentalFeature object to the initialization params of ManifestManager * create event filters artifacts if feature flag is on * change artifact migration to be less chatty in the logs (also: don't reference Fleet)
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…iltering (#96499) (#96811) * generate endpoint event filters artifacts * Add ExperimentalFeature object to the initialization params of ManifestManager * create event filters artifacts if feature flag is on * change artifact migration to be less chatty in the logs (also: don't reference Fleet) Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
Summary
eventFilteringEnabled
config setting is set)Testing
Click here to view the different tests that were manually done
With feature flag turned off
With feature flag turned on