Cross cluster search discover - additional tests for persisted query and phrases filter #96518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmivkulkarni
added
Feature:Cross Cluster Search
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Seems more related to @elastic/kibana-app's scope? |
|
Should this PR aim to |
jbudz
approved these changes
Apr 8, 2021
Bamieh
approved these changes
Apr 12, 2021
| it('should add a phrases filter', async function () { | ||
| await PageObjects.discover.selectIndexPattern('data:makelogs工程-*,local:makelogs工程-*'); | ||
| const hitCountNumber = await PageObjects.discover.getHitCount(); | ||
| const originalHitCount = parseInt(hitCountNumber.replace(/\,/g, '')); |
There was a problem hiding this comment.
Suggested change
| const originalHitCount = parseInt(hitCountNumber.replace(/\,/g, '')); | |
| const originalHitCount = parseInt(hitCountNumber.replace(/\,/g, ''), 10); |
Sometimes javascript guesses the radix wrong. Explicitly specifying base 10 is a safer bet.
| await queryBar.submitQuery(); | ||
| await retry.try(async () => { | ||
| const hitCountNumber = await PageObjects.discover.getHitCount(); | ||
| const hitCount = parseInt(hitCountNumber.replace(/\,/g, '')); |
There was a problem hiding this comment.
Suggested change
| const hitCount = parseInt(hitCountNumber.replace(/\,/g, '')); | |
| const hitCount = parseInt(hitCountNumber.replace(/\,/g, ''), 10); |
| expect(await filterBar.hasFilter('extension.keyword', 'jpg')).to.be(true); | ||
| await retry.try(async () => { | ||
| const hitCountNumber = await PageObjects.discover.getHitCount(); | ||
| const hitCount = parseInt(hitCountNumber.replace(/\,/g, '')); |
There was a problem hiding this comment.
Suggested change
| const hitCount = parseInt(hitCountNumber.replace(/\,/g, '')); | |
| const hitCount = parseInt(hitCountNumber.replace(/\,/g, ''), 10); |
|
covered by #96669 , hence closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @LeeDr