Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix transferable logic to handle newer operations on datasource change #96617

Merged
merged 3 commits into from
Apr 12, 2021
Merged

[Lens] Fix transferable logic to handle newer operations on datasource change #96617

merged 3 commits into from
Apr 12, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Apr 8, 2021

Summary

Fixes #95278

This PR adds some additional logic when checking for transferable columns on new datasources.

New referencing operations require a time field to be present AND compatible "indirect" fields.

If new datasource does not satisfy both criteria:

Kapture 2021-04-08 at 19 36 03

If datasource does not satisfy one of the criteria:
Kapture 2021-04-08 at 19 38 11

Checklist

@dej611 dej611 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 8, 2021
@dej611 dej611 requested a review from a team April 8, 2021 17:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dej611
Copy link
Contributor Author

dej611 commented Apr 12, 2021

@elasticmachine merge upstream

@dej611
Copy link
Contributor Author

dej611 commented Apr 12, 2021

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 942.0KB 942.2KB +206.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 3cf5995 into elastic:master Apr 12, 2021
@dej611 dej611 deleted the fix/95278 branch April 12, 2021 14:56
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 12, 2021
@dej611 @kibanamachine
[Lens] Fix transferable logic to handle newer operations on datasourc…
6fea3ff 
…e change (elastic#96617)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Apr 12, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 12, 2021
@kibanamachine @dej611
[Lens] Fix transferable logic to handle newer operations on datasourc…
01b2aaa 
…e change (#96617) (#96797)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Switching datasource in the Layer panel does not clean up reference operation dimensions
4 participants
@dej611 @elasticmachine @kibanamachine @flash1293