Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Moves the transaction type selector to the search bar #96685

Merged

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Apr 9, 2021

Closes #91131.

  • Replaces the prepend label on the search bar with the transaction type selector
  • Adds the transaction type selector to the service overview page
  • Removes title from the Transactions list page

Screen Shot 2021-04-09 at 12 41 52 AM

ogupte added 2 commits April 8, 2021 16:04
…ype selector

- Adds the transaction type selector to the service overview page
- Removes title from the Transactions list page
@ogupte ogupte requested a review from a team as a code owner April 9, 2021 04:44
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Apr 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte
Copy link
Contributor Author

ogupte commented Apr 9, 2021

retest

@ogupte
Copy link
Contributor Author

ogupte commented Apr 12, 2021

@elasticmachine merge upstream

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.2MB 4.2MB -1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit eb25c69 into elastic:master Apr 12, 2021
ogupte added a commit to ogupte/kibana that referenced this pull request Apr 12, 2021
…96685)

* [APM] Moves the Transaction type selector to the search bar (elastic#91131)

* - Replaces the prepend label on the search bar with the transaction type selector
- Adds the transaction type selector to the service overview page
- Removes title from the Transactions list page

* removes unused i18n items

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ogupte added a commit that referenced this pull request Apr 12, 2021
…96850)

* [APM] Moves the Transaction type selector to the search bar (#91131)

* - Replaces the prepend label on the search bar with the transaction type selector
- Adds the transaction type selector to the service overview page
- Removes title from the Transactions list page

* removes unused i18n items

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:APM All issues that need APM UI Team support v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Move the Transaction type selector to the search bar
4 participants