Exclude non-persisted sessions from SO migration #96938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
rudolf
approved these changes
Apr 13, 2021
Dosant
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Tested, looks good,
I created a 7.12.0 cluster locally and generated sessions there.
Then I run from the source of the branch and tested that only "persisted:true" sessions were migrated to the new kibana index.
I tested only the default migration mechanism (I assume this was v2)
Just a note: old sessions are not deleted. They stay in the old index. I assume this is expected
|
Pinging @elastic/kibana-core (Team:Core) |
11 tasks
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Apr 13, 2021
pgayvallet
added a commit
to rudolf/kibana
that referenced
this pull request
Apr 13, 2021
(cherry picked from commit bfd5b7b)
pgayvallet
added a commit
that referenced
this pull request
Apr 13, 2021
pgayvallet
added a commit
that referenced
this pull request
Apr 13, 2021
…sted sessions (#96938) (#96892) * Migrations v2 ignore fleet agent events (#96690) * migrationsv2: ignore fleet agent events and tsvb telemetry * migrationsv1: ignore tsvb-validation-telemetry * Skip fleet test that depends on fleet-agent-events * Fix typescript errors Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/core/server/saved_objects/migrationsv2/integration_tests/actions.test.ts * Correctly fix merge conflicts * Skip failing fleet-agent-events tests * Skip security solution endpoint telemetry tests depending on fleet-agent-events so's * Exclude non-persisted sessions from SO migration (#96938) (cherry picked from commit bfd5b7b) * use `any` for estypes.QueryContainer Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@gmail.com>
rudolf
added
the
project:ResilientSavedObjectMigrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #96131
Exclude non persisted (
search-session.persisted: false) search sessions (type: 'search-session') during SO migrationChecklist