Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): moving @kbn/utility-types into bazel #97151

Merged
merged 4 commits into from
Apr 15, 2021
Merged

chore(NA): moving @kbn/utility-types into bazel #97151

merged 4 commits into from
Apr 15, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Apr 14, 2021

One step forward on #69706

That PR moves the @kbn/utility-types into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@mistic mistic added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.13.0 v8.0.0 chore labels Apr 14, 2021
@mistic mistic marked this pull request as ready for review April 14, 2021 17:27
@mistic mistic requested a review from a team as a code owner April 14, 2021 17:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from jbudz April 14, 2021 17:28
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

jen-huang
jen-huang approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM

jbudz
jbudz approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows. LGTM.

@mistic mistic added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 2bb97f2 into elastic:master Apr 15, 2021
@kibanamachine kibanamachine mentioned this pull request Apr 15, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 15, 2021
@mistic @kibanamachine
chore(NA): moving @kbn/utility-types into bazel (elastic#97151)
a3f1ed4 
* chore(NA): moving @kbn/utility-types into bazel

* chore(NA): solve ts config errors
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 15, 2021
@kibanamachine @mistic
chore(NA): moving @kbn/utility-types into bazel (#97151) (#97199)
9b326c6 
* chore(NA): moving @kbn/utility-types into bazel

* chore(NA): solve ts config errors

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
@mistic mistic mentioned this pull request Apr 28, 2021
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@jen-huang jen-huang jen-huang approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Operations Team label for Operations Team v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibanamachine @jen-huang @jbudz