Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): moving @kbn/babel-code-parser into bazel #97675

Merged
merged 13 commits into from
Apr 23, 2021
Merged

chore(NA): moving @kbn/babel-code-parser into bazel #97675

merged 13 commits into from
Apr 23, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Apr 20, 2021

One step forward on #69706

That PR moves the @kbn/babel-code-parser into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 20, 2021
@mistic

This comment has been minimized.

Sign in to view
@mistic

This comment has been minimized.

Sign in to view
@mistic mistic added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
@mistic

This comment has been minimized.

Sign in to view
@kibanamachine

This comment has been minimized.

Sign in to view
@mistic mistic marked this pull request as ready for review April 22, 2021 16:35
@mistic mistic requested a review from a team April 22, 2021 16:35
@mistic mistic requested review from a team as code owners April 22, 2021 16:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jbudz
jbudz approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@spalger
Copy link
Contributor

spalger commented Apr 22, 2021

jenkins, test this (necessary for Jenkins update)

wylieconlon
wylieconlon approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested tinymath changes, LGTM

tsullivan
tsullivan approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app services changes LGTM

@mistic

This comment has been minimized.

Sign in to view
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
globalSearch 13 - -13
licenseApiGuard 8 - -8
total -21

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
globalSearch 6 - -6
Unknown metric groups

API count

id before after diff
globalSearch 67 - -67
licenseApiGuard 8 - -8
total -75

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 00940dd into elastic:master Apr 23, 2021
@kibanamachine kibanamachine mentioned this pull request Apr 23, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 23, 2021
@mistic @kibanamachine
chore(NA): moving @kbn/babel-code-parser into bazel (elastic#97675)
a00b0d2 
* chore(NA): moving @kbn/babel-code-parser into bazel

* docs(NA): missing docs about new package

* chore(NA): removing quiet arg

* chore(NA): fix packages build srcs

* chore(NA): change source order on tinymath

* chore(NA): add babelrc

* chore(NA): clear package build migration

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 23, 2021
@kibanamachine @mistic
chore(NA): moving @kbn/babel-code-parser into bazel (#97675) (#98185)
fd17880 
* chore(NA): moving @kbn/babel-code-parser into bazel

* docs(NA): missing docs about new package

* chore(NA): removing quiet arg

* chore(NA): fix packages build srcs

* chore(NA): change source order on tinymath

* chore(NA): add babelrc

* chore(NA): clear package build migration

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
@mistic mistic mentioned this pull request Apr 28, 2021
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@tsullivan tsullivan tsullivan approved these changes

@wylieconlon wylieconlon wylieconlon approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mistic @kibanamachine @elasticmachine @spalger @wylieconlon @tsullivan @pgayvallet @jbudz