Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): chore(NA): moving @kbn/utils into bazel #97833

Merged
merged 3 commits into from
Apr 22, 2021
Merged

chore(NA): chore(NA): moving @kbn/utils into bazel #97833

merged 3 commits into from
Apr 22, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Apr 21, 2021 •
edited
Loading

One step forward on #69706

That PR moves the @kbn/utils into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 21, 2021
@mistic mistic mentioned this pull request Apr 21, 2021
Closed
23 tasks
@mistic mistic marked this pull request as ready for review April 22, 2021 02:14
@mistic mistic requested review from vigneshshanmugam and a team as code owners April 22, 2021 02:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afharo
afharo approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbudz
jbudz approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

vigneshshanmugam
vigneshshanmugam approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes looks good.

@mistic mistic merged commit a8a8289 into elastic:master Apr 22, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 22, 2021
@mistic @kibanamachine
chore(NA): chore(NA): moving @kbn/utils into bazel (elastic#97833)
168242e 
* chore(NA): chore(NA): moving @kbn/utils into bazel

* chore(NA): run kbn-test integration test with preserve-symlinks
@kibanamachine kibanamachine mentioned this pull request Apr 22, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 22, 2021
@kibanamachine @mistic
chore(NA): chore(NA): moving @kbn/utils into bazel (#97833) (#98056)
673c0c6 
* chore(NA): chore(NA): moving @kbn/utils into bazel

* chore(NA): run kbn-test integration test with preserve-symlinks

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mistic @elasticmachine @kibanamachine @jbudz @vigneshshanmugam @afharo