Fix malformed geo alerts call to transformResults

[kindsun]

This fixes a regression introduced in #93364 where the body field was incorrectly appended to currentIntervalResults. This resulted in an undefined value being passed to the function.

To test, set up a normal geo containment alert (see readme). Alerts triggered by both entering and leaving shapes were tested and found working

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[kindsun]

@elasticmachine merge upstream

[thomasneirynck]

thx for the forensics on this, and the quick fix.

I would look into if we can add a unit-test on the getGeoContainmentExecutor. It has some end-2-end glue-code, that is not getting covered right now. This is an opportunity to add some coverage. (it's also the API-extension point of alerting-framework, which helps).

For this test, there's already have an example of a mock on alertInstanceFactory . I think it would only require one more additional mock for the services.scopedClusterClient.asCurrentUser esClient. That mock could just return two sample ES-responses: One for the shapes (

kibana/x-pack/plugins/stack_alerts/server/alert_types/geo_containment/es_query_builder.ts

Line 52 in 238791b

const { body: boundaryData }: ApiResponse<Record<string, any>> = await esClient.search({

) when it is called, and one for the top-hits agg when it is called (

kibana/x-pack/plugins/stack_alerts/server/alert_types/geo_containment/es_query_builder.ts

Line 198 in 238791b

({ body: esResult } = await esClient.search(esQuery));

)

[thomasneirynck]

thx, discussed offline. Unit test looks good, but would mock at more lower-level, the actual search of the esClient.

along the lines of:

    //
      alertServices.scopedClusterClient.callAsUser = {
        search: (...args) = {
          if (isShapeSearchCall) {
            return  sampleESShapeSearchReturn;
          } else if (isTophItsCall) {
            return sampleESTopHitsAggReturn;
          }
        }/
      };

^ this should give us more comprehensive "round trip" behavior, thx!

[thomasneirynck]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: afc3310
• Storybooks Preview
• Documentation Changes

Metrics [docs]

✅ unchanged

History

• 💚 Build #123624 succeeded 3b2bedd
• 💚 Build #123411 succeeded 3c337ff
• 💔 Build #123107 failed 38a6a9b
• 💚 Build #121901 succeeded 58f5e55a4a5c82c25abb7f047249432bcd17a9fa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[thomasneirynck]

code review, thx for adding the comprehensive tests