[Fleet] Use 9243 as default port for cloud URLs

[nchaulet]

Summary

Resolve #98356

In Fleet we are populating the ES hosts and Fleet server hosts used by the agent to communicate with ES or Fleet Server from the cloud ID.
If there is no default port in the cloud ID we were defaulting to 443 but after some discussions looks like the default port both for ECE and ESS is 9243. That PR makes the change.

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[jen-huang]

Thanks for the quick turnaround!

[jen-huang]

out of scope for this PR, but this kind of information seems like it should be exported from cloud plugin

[nchaulet]

Yes actually the whole decode_cloud_id service should probably exported by the cloud plugin.

[AlexP-Elastic]

LGTM (will just mention that when it was discussed yesterday in a similar context, @simitt was in favor of hiding the port if it was ==443)

[nchaulet]

LGTM (will just mention that when it was discussed yesterday in a similar context, @simitt was in favor of hiding the port if it was ==443)

Yes we hide it.

[AlexP-Elastic]

Ugh so I did some digging and the old beats code treats the default port as 443 :/ https://github.com/elastic/beats/blob/23e4403ae093fcc8f7905345cad2c7ad256976d8/libbeat/cloudid/cloudid.go#L34

@nchaulet did you say you had seen a case where the port wasn't present and it should have been 9243? (eg an ECE instance)

I'm digging up an ECE instance now to check

[nchaulet]

Looks like there is one case here #98356 not sure what the cloud ID was

[jfsiii]

I am headed out the door, but wanted to add some background. The original PR #65366 said

Adds decodeCloudId function based on code & tests in libbeat

Which seems to use 443 (but I'm not able to really process & be sure right now)

Happy to see this ship if it's what we want now. Just linking for more context

[AlexP-Elastic]

I found this in an internal knowledgebase:

Initially the cloud id was available from ECE version 1.2.0 in this initial release the format did not support (nor did beats/logstash) a dedicated port number and so it defaulted to 443. This was fine for ESS but many ECE installations only support the default 9243 port and so clients configured with the ECE cloud id would fail to connect.

In ECE release 2.2 the format was extended to allow a port to be configured and for new ECE 2.2 installations this port would default to 9243. However because we couldn't be certain of customers network configurations and which ones may already be dependent on using a 443 configuration we decided not to implement an upgrade to explicitly introduce this configuration setting.

[AlexP-Elastic]

I found a better specification of what is going on:

  * Generates a cloud id from the given elasticsearch/kibana cluster ids and display name, it will attempt to retrieve the
  * cname and port from zookeeper, if the port is not available it will default to `9243`, if the port equals 443 it will
  * be only use the cname.

So there are two different "defaults" here:

• For a given ECE region, the port will default to 9243 unless overridden
• Within the cloud Id, if the port is not specified then it should be assumed to be 443

Therefore I believe the code as it was before this PR is correct. 1000 apologies for the confusion

[nchaulet]

Probably no need for that

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: be364a2
• Storybooks Preview

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
fleet	346.8KB	346.8KB	+2.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet