Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[packages] Move @kbn/legacy-logging to Bazel #98810

Merged
merged 5 commits into from
Apr 30, 2021
Merged

[packages] Move @kbn/legacy-logging to Bazel #98810

merged 5 commits into from
Apr 30, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Apr 29, 2021

Part of #69706

That PR moves the @kbn/legacy-logging into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@jbudz jbudz added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Apr 29, 2021
@jbudz jbudz requested a review from a team as a code owner April 29, 2021 18:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

mistic
mistic reviewed Apr 29, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there I think @jbudz aside from the comments I let above, can we also remove the npm scripts of the package from its package.json?

packages/kbn-legacy-logging/BUILD.bazel Outdated Show resolved Hide resolved
packages/kbn-legacy-logging/BUILD.bazel Outdated Show resolved Hide resolved
@mistic mistic mentioned this pull request Apr 29, 2021
Closed
23 tasks
@jbudz
Copy link
Member Author

jbudz commented Apr 29, 2021 •
edited
Loading

Thanks mistic! npm scripts removed with 037e194.

mistic
mistic approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 30, 2021
@jbudz jbudz merged commit 3d8f1b1 into elastic:master Apr 30, 2021
@jbudz jbudz deleted the bazel/legacy-logging branch April 30, 2021 19:34
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 30, 2021
@jbudz @kibanamachine
[packages] Move @kbn/legacy-logging to Bazel (elastic#98810)
c234a3e
@kibanamachine kibanamachine mentioned this pull request Apr 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 1, 2021
@kibanamachine @jbudz
[packages] Move @kbn/legacy-logging to Bazel (#98810) (#98973)
719b380 
Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbudz @elasticmachine @kibanamachine @lukeelmers @mistic