[Fleet] Fix fleet server host port during settings creation #99084
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
added
the
release_note:skip
jen-huang
approved these changes
May 3, 2021
|
Is there a way to have some automated tests for this to confirm it works as expected? Is this URL also exposed through the API? |
I added some unit tests before but it was not good enough so just added a new API integration test that set the settings 5a5487b |
ruflin
reviewed
May 3, 2021
kpollich
reviewed
May 3, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
May 4, 2021
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
May 4, 2021
nchaulet
added a commit
that referenced
this pull request
May 4, 2021
nchaulet
added a commit
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix after #98957
I made a change to make the port explicit in the fleet server host url, but this fix was only applied on update not when we create the settings.
That PR fix it.