-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fix fleet server host port during settings creation #99084
[Fleet] Fix fleet server host port during settings creation #99084
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 thanks for catching this!
Is there a way to have some automated tests for this to confirm it works as expected? Is this URL also exposed through the API? |
I added some unit tests before but it was not good enough so just added a new API integration test that set the settings 5a5487b |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
Summary
Fix after #98957
I made a change to make the port explicit in the fleet server host url, but this fix was only applied on update not when we create the settings.
That PR fix it.