[Fleet] Add default http|https port to ES hosts #99240
Merged
+159
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
commented
May 4, 2021
nchaulet
added
the
auto-backport
jfsiii
approved these changes
May 4, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 4, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 4, 2021
kibanamachine
added a commit
that referenced
this pull request
May 5, 2021
kibanamachine
added a commit
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #98356
The Elastic agent is using
9200as a default port for Elasticsearch, so if in the Fleet settings you use something like thishttp://elasticsearch.frthe agent is going to usehttp://elasticsearch.fr:9220as the ES host.Recently we decided for the Fleet server hosts to explicitly set the port for default http|https port so
http://fleetserver.frwill be saved ashttp://fleetserver.fr:80and the agent will usehttp://fleetserver.fr:80as fleet server host.That PR is doing the same for the the ES host.
Also I added some basic API integration test for the output crud as we do not have any