-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Add layer edit controls #99812
Conversation
@aaronjcaldwell @nreese, I pushed a few design changes with 95e97c1. I changed the icons. The layer settings or "Edit layer" is now using the old icon. The edit features is now using the "vector" icon. Another change is the active state in the toolbar now is more prominent. The hover keeps the same. When we are feature editing the background in the layer panel highlights. I don't think we need the dashed red border. After this, we need to open a new PR with some design changes. We can discuss it tomorrow in our meeting. You can find the prototype here. But the main idea is that the exit button would move to the highlighted layer and also we would add a badge saying that we are in "drawing mode". |
...lugins/maps/public/connected_components/toolbar_overlay/tools_control/tools_control.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/connected_components/toolbar_overlay/toolbar_overlay.tsx
Outdated
Show resolved
Hide resolved
...ls/layer_control/layer_toc/toc_entry/toc_entry_actions_popover/toc_entry_actions_popover.tsx
Outdated
Show resolved
Hide resolved
...yer_control/layer_toc/toc_entry/toc_entry_actions_popover/toc_entry_actions_popover.test.tsx
Outdated
Show resolved
Hide resolved
...ls/layer_control/layer_toc/toc_entry/toc_entry_actions_popover/toc_entry_actions_popover.tsx
Outdated
Show resolved
Hide resolved
...ls/layer_control/layer_toc/toc_entry/toc_entry_actions_popover/toc_entry_actions_popover.tsx
Outdated
Show resolved
Hide resolved
@miukimiu Thanks for the clean-up 🙇 ! Changes look good to me for this PR. Looking forward to your next pass on edit tools in a separate PR, the preview shot of what that will look like looks great! Let me know if there are any more changes you'd like to get in for this PR or if you need any updates from me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good. Just some minor comments
...ls/layer_control/layer_toc/toc_entry/toc_entry_actions_popover/toc_entry_actions_popover.tsx
Outdated
Show resolved
Hide resolved
...ls/layer_control/layer_toc/toc_entry/toc_entry_actions_popover/toc_entry_actions_popover.tsx
Outdated
Show resolved
Hide resolved
.../connected_components/right_side_controls/layer_control/layer_toc/toc_entry/action_labels.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/connected_components/mb_map/tooltip_control/tooltip_popover.test.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a design perspective, it looks good. We're using the right icons, colors and the toolbar now has better states. 🎉
As I commented on #99812 (comment) we decided to improve the user flow in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for sticking with all the review comments. This PR turned out really nice and its great to be able to draw features and index them.
Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
Adds layer edit control toolbar for any index-based layer in the Maps app as part of #96836.
To test, add
xpack.maps.enableDrawingFeature: true
to yourkibana.yml
Functionality this PR adds:
What this PR doesn't add, but is planned for the future:
How to edit features:
Edit features
in pop-up menuaustralia_states_v1.geo.zip