-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix filter_func logging for config.debug=true #8456
Closed
original-brownbear
wants to merge
1
commit into
elastic:master
from
original-brownbear:fix-debug-logging-for-filter_func
Closed
BUG: Fix filter_func logging for config.debug=true #8456
original-brownbear
wants to merge
1
commit into
elastic:master
from
original-brownbear:fix-debug-logging-for-filter_func
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
approved these changes
Oct 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested and confirmed patch makes the test pass
@jsvd thanks merging :) |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Oct 9, 2017
Armin Braun merged this into the following branches!
|
elasticsearch-bot
pushed a commit
that referenced
this pull request
Oct 9, 2017
original-brownbear
added a commit
to original-brownbear/logstash
that referenced
this pull request
Oct 9, 2017
original-brownbear
added a commit
to original-brownbear/logstash
that referenced
this pull request
Oct 9, 2017
elasticsearch-bot
pushed a commit
that referenced
this pull request
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error reported by @ruflin :
that resulted from
events
now being an[]
forfilter
here as a result of #8428.I know this isn't 100% perfect since we're now not logging each event before it hits the filter itself, but rather logging the whole batch before running the filter on it.
But the
multi_filter
method onFilterDelegator
simply is what it is and works on batches instead of single events.