Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Correcting model state min_version #1546

Merged
merged 2 commits into from
Oct 26, 2020
Merged

[ML] Correcting model state min_version #1546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5d90e6
[ML] Correcting model state min_version
droberts195 Oct 26, 2020
a8cbeff
Adjusting comment and adding changelog
droberts195 Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
* Avoid potential "Failed to compute quantile" and "No values added to quantile sketch" log errors
training regression and classification models if there are features with mostly missing values.
(See {ml-pull}1500[#1500].)
* Correct the anomaly detection job model state `min_version`. (See {ml-pull}1546[#1546].)

== {es} version 7.9.2

Expand Down
7 changes: 6 additions & 1 deletion lib/api/CAnomalyJob.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,12 @@ const std::string INTERIM_BUCKET_CORRECTOR_TAG("k");

//! The minimum version required to read the state corresponding to a model snapshot.
//! This should be updated every time there is a breaking change to the model state.
const std::string MODEL_SNAPSHOT_MIN_VERSION("6.4.0");
//! Newer versions are able to read the model state of older versions, but older
//! versions cannot read the model state of newer versions following a breaking
//! change. This constant tells the node assignment code not to load new model states
//! on old nodes in a mixed version cluster. (The last breaking change was in 7.9 in
//! lib/core/CPackedBitVector.cc in https://github.com/elastic/ml-cpp/pull/1340.)
const std::string MODEL_SNAPSHOT_MIN_VERSION("7.9.0");
tveasey marked this conversation as resolved.
Show resolved Hide resolved

//! Persist state as JSON with meaningful tag names.
class CReadableJsonStatePersistInserter : public core::CJsonStatePersistInserter {
Expand Down