Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-dependent-jobs action #16

Merged
merged 25 commits into from
Jun 4, 2024
Merged

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented May 30, 2024

will be handy for testing in this repo where the test status check is expected

@reakaleek reakaleek marked this pull request as draft May 30, 2024 07:24
@reakaleek reakaleek self-assigned this May 30, 2024
@reakaleek reakaleek added the changelog:feature When you add a new feature label May 30, 2024
@reakaleek reakaleek requested a review from a team May 30, 2024 07:54
@reakaleek reakaleek marked this pull request as ready for review May 30, 2024 07:54
@reakaleek reakaleek requested a review from v1v June 3, 2024 08:58
.github/workflows/test-check-dependent-jobs.yml Outdated Show resolved Hide resolved
.github/workflows/test-check-dependent-jobs.yml Outdated Show resolved Hide resolved
check-dependent-jobs/README.md Outdated Show resolved Hide resolved
check-dependent-jobs/action.yml Outdated Show resolved Hide resolved
check-dependent-jobs/action.yml Show resolved Hide resolved
@v1v
Copy link
Member

v1v commented Jun 3, 2024

I'm not sure, I guess we could potentially support some extra arguments:

with:
  compare: all
  status: failure

with:
  compare: any
  status: failure

with:
  compare: none
  status: success

or something along those lines...

@reakaleek
Copy link
Member Author

@v1v woops. Deleted the comment

@reakaleek
Copy link
Member Author

reakaleek commented Jun 4, 2024

I'm not sure, I guess we could potentially support some extra arguments:

with:
  compare: all
  status: failure

with:
  compare: any
  status: failure

with:
  compare: none
  status: success

or something along those lines...

Sounds like it could be an enhancement in a follow-up.

I will merge this for now as we have some usages of this with this functionality already.

@reakaleek reakaleek merged commit 0a5c22a into main Jun 4, 2024
13 checks passed
@reakaleek reakaleek deleted the feature/check-dependent-jobs-action branch June 4, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:feature When you add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants