Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use v1 for the time being #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

v1v
Copy link
Member

@v1v v1v commented Jun 19, 2024

As long as we don't have a way to centralise those inter-dependencies somehow let's use v1.

I'd probably say if we use v1 then all the relevant dependencies should be using v1, if we use v1.9.1 then all the dependencies should point to that particular version regardless

@v1v v1v added the changelog:fix When you fix a bug label Jun 19, 2024
@v1v v1v requested a review from reakaleek June 19, 2024 12:13
@v1v v1v self-assigned this Jun 19, 2024
@v1v
Copy link
Member Author

v1v commented Jun 19, 2024

I'm not sure how to proceed here, there will be always a version below of the one we hav.e released.

@reakaleek
Copy link
Member

I'm not sure how to proceed here, there will be always a version below of the one we hav.e released.

I don't think it matters if there are no changes to the related actions.

But generally, it would be a 2 step release.

first, release the inner action with the changes
secondly, create a new release with the updated version

@v1v
Copy link
Member Author

v1v commented Jul 8, 2024

first, release the inner action with the changes
secondly, create a new release with the updated version

That will cause a recurrent bump and dependabot will create PRs over and over:

I'm not sure how to proceed here

@reakaleek
Copy link
Member

reakaleek commented Jul 8, 2024

first, release the inner action with the changes
secondly, create a new release with the updated version

That will cause a recurrent bump and dependabot will create PRs over and over:

I'm not sure how to proceed here

Yes, this is true. But if you have already released two releases with changes to the inner and outer dependency, the last update by Dependabot doesn't affect their behavior.

Hence, we can just merge it and don't do a release until we need or want to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fix When you fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants