oblt-cli/setup: version input precedence
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
force-pushed
the
feature/fix-version-version-file-precedence
branch
from
e66c3c6
to
ebcfe0b
Compare
reakaleek
changed the title
version over version-fileversion input precedence
v1v
reviewed
Jul 2, 2024
| else | ||
| echo "[ERROR] ${OBLT_CLI_VERSION_FILE} file not found." | ||
| echo "::error title=elastic/oblt-actions/oblt-cli/setup::version-file not found: ${version_file}" |
There was a problem hiding this comment.
If version is nil, what's the reason this condition fails rather than installing the latest version?
I see # Downloads the latest release if OBLT_CLI_VERSION is not set is not anymore the case.
There was a problem hiding this comment.
I removed the comment. But I think the behavior already changed in #54
There was a problem hiding this comment.
- uses: elastic/oblt-actions/oblt-cli/setup@v1
with:
github-token: ${{ secrets.PAT }}
version: ""Maybe version: "" is not valid but version: latest as you pointed out earlier. Then this comment/error can be set in that particular case. WDYT?
v1v
reviewed
Jul 2, 2024
For the reason mentioned in #73 (comment) Also, the |
v1v
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not a breaking change because #69 has not been released yet.
This change makes the action prefer the
versioninput if bothversionandversion-fileare defined.Additionally, it will add a warning annotation.
It will also add a notice annotation informing you about the downloaded version.