Update quick starts for 7.16 #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorelli25
commented
Nov 8, 2021
| @@ -63,7 +63,7 @@ installation package. | |||
| -- | |||
| // tag::install-elastic-agent[] | |||
|
|
|||
| include::{tab-widgets}/download-widget.asciidoc[] | |||
There was a problem hiding this comment.
These {tab-widgets} attributes are nice, but they don't allow cross-doc includes (as far as I can tell)
|
A documentation preview will be available soon: |
bmorelli25
commented
Nov 8, 2021
Comment on lines
+147
to
+154
| // this if directive includes the same file, but changes the file path based on where this guide is built | ||
| ifndef::apm-integration-docs[] | ||
| include::{apm-repo-dir}/legacy/tab-widgets/install-agents-widget.asciidoc[] | ||
| endif::[] | ||
|
|
||
| ifdef::apm-integration-docs[] | ||
| include::{docdir}/legacy/tab-widgets/install-agents-widget.asciidoc[] | ||
| endif::[] |
There was a problem hiding this comment.
This is a bit of a mess, but it's the only way I could include this file in both the Observability Guide and APM Guide. Without the if directive, the file would error in one of the books.
Comment on lines
+8
to
+9
| // THIS CONTENT IS ALSO USED IN THE APM GUIDE | ||
| // tag::apm-quick-start[] |
There was a problem hiding this comment.
This tag allows the content to be reused in the APM Guide.
bmorelli25
added a commit
to bmorelli25/observability-docs
that referenced
this pull request
Nov 11, 2021
* docs: new screenshots * docs: update text * docs: use aboslute file paths instead of attrs * docs: remove extra include
bmorelli25
added a commit
to bmorelli25/observability-docs
that referenced
this pull request
Nov 11, 2021
* docs: new screenshots * docs: update text * docs: use aboslute file paths instead of attrs * docs: remove extra include
bmorelli25
added a commit
that referenced
this pull request
Nov 11, 2021
bmorelli25
added a commit
that referenced
this pull request
Nov 11, 2021
bmorelli25
added a commit
to bmorelli25/observability-docs
that referenced
this pull request
Apr 11, 2023
* docs: new screenshots * docs: update text * docs: use aboslute file paths instead of attrs * docs: remove extra include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the traces quick start and logs/metrics/uptime quick start for 7.16. It also updates the includes so that the traces quick start guide can be reused in the APM Guide in the APM Server repo.
Related
For #1073
For #1231
elastic/docsPR: elastic/docs#2281elastic/apm-serverPR: elastic/apm-server#6554