Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude _build from ALL_MODULES #161

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 4, 2024

Rewrite filtering of files when discovering modules to use find options and exclude _build directory.

Including _build makes some targets to fail if the directory exists:

$ make gotest
make[1]: Entering directory '/home/jaime/gocode/src/github.com/elastic/opentelemetry-collector-components'
Running target 'test' in module '_build'
make -C _build test
make[2]: Entering directory '/home/jaime/gocode/src/github.com/elastic/opentelemetry-collector-components/_build'
make[2]: *** No rule to make target 'test'.  Stop.
make[2]: Leaving directory '/home/jaime/gocode/src/github.com/elastic/opentelemetry-collector-components/_build'
make[1]: *** [Makefile:25: _build] Error 2
make[1]: Leaving directory '/home/jaime/gocode/src/github.com/elastic/opentelemetry-collector-components'
make: *** [Makefile:37: gotest] Error 2

@jsoriano jsoriano requested a review from a team as a code owner October 4, 2024 08:14
@rogercoll rogercoll merged commit c3a971a into elastic:main Oct 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants