Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust config options and naming for template.* #394

Closed
ruflin opened this issue Apr 28, 2020 · 4 comments
Closed

Adjust config options and naming for template.* #394

ruflin opened this issue Apr 28, 2020 · 4 comments
Assignees
@ruflin
Labels
Ingest Management:beta1 Group issues for ingest management beta1

Comments

@ruflin
Copy link
Contributor

ruflin commented Apr 28, 2020

In #346 (comment) a template_path was introduced but is not the optimal name. This issue is to follow up on this conversation and implement potential changes.
@ruflin ruflin mentioned this issue Apr 29, 2020
Merged
@ruflin ruflin added the Ingest Management:beta1 Group issues for ingest management beta1 label Apr 30, 2020
@ruflin
Copy link
Contributor Author

ruflin commented Jul 2, 2020

As we got rid of template_content we could go back to just call this template. At the same time I would like to have some unified naming on path / src etc. across the manifest. @mtojek @ph @ycombinator Feedback welcome.

@ruflin
Copy link
Contributor Author

ruflin commented Sep 18, 2020

@mtojek @ycombinator WDYT, should be keep the name template_path as is or change it? To not introduce any breaking changes, I would probably just keep it for now and close this.

@mtojek
Copy link
Contributor

mtojek commented Sep 18, 2020

IMHO the template_path is more descriptive than template.

@ruflin
Copy link
Contributor Author

ruflin commented Sep 18, 2020

Closing for now, please reopen if someone disagrees.

@ruflin ruflin closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruflin ruflin

Labels
Ingest Management:beta1 Group issues for ingest management beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ruflin @mtojek