-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest] Use agent template embeded in the pkg registry response #64705
[Ingest] Use agent template embeded in the pkg registry response #64705
Conversation
157f2b3
to
a9dc64e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, didn't test locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't run, but everything reads well.
Only comment is two small language issues. I believe the error messages should be "unable to find ..."
There are two issues related to this:
Especially for the second one, I think there should be a summary somewhere but probably KB should take care of it when it downloads the package for the first time. |
@ruflin Are you ok to merge it like this for alpha so we can support |
@nchaulet yes |
@elasticmachine merge upstream |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
Summary
A few weeks ago @ruflin made a change to have agent stream template embedded in the response elastic/package-registry#335
We should use that instead of making an extra call to get the stream, also our code was not working for stream that were not named
stream.yml
(stream.yml.hbs
)