Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest] Use agent template embeded in the pkg registry response #64705

Conversation

nchaulet
Copy link
Member

Summary

A few weeks ago @ruflin made a change to have agent stream template embedded in the response elastic/package-registry#335

We should use that instead of making an extra call to get the stream, also our code was not working for stream that were not named stream.yml (stream.yml.hbs)

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 28, 2020
@nchaulet nchaulet requested a review from a team April 28, 2020 21:50
@nchaulet nchaulet self-assigned this Apr 28, 2020
@nchaulet nchaulet force-pushed the feature-ingest-use-agent-template-from-pkg-info branch from 157f2b3 to a9dc64e Compare April 28, 2020 21:55
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't test locally

@jfsiii jfsiii self-requested a review April 28, 2020 23:36
Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't run, but everything reads well.

Only comment is two small language issues. I believe the error messages should be "unable to find ..."

@ruflin
Copy link
Contributor

ruflin commented Apr 29, 2020

There are two issues related to this:

Especially for the second one, I think there should be a summary somewhere but probably KB should take care of it when it downloads the package for the first time.

@nchaulet
Copy link
Member Author

nchaulet commented Apr 29, 2020

@ruflin Are you ok to merge it like this for alpha so we can support agent.yml.hbs template? and we can revisit how we build this for the beta. And yes kibana is probably the best candidate to build this resume.

@ruflin
Copy link
Contributor

ruflin commented Apr 29, 2020

@nchaulet yes

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit f8dc041 into elastic:master Apr 29, 2020
@nchaulet nchaulet deleted the feature-ingest-use-agent-template-from-pkg-info branch April 29, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants