Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Include 'constraints' and 'owner' in /search responses #731

Closed
andrewkroh opened this issue Sep 22, 2021 · 0 comments · Fixed by #734
Closed

[Enhancement] Include 'constraints' and 'owner' in /search responses #731

andrewkroh opened this issue Sep 22, 2021 · 0 comments · Fixed by #734
Labels
discussion enhancement New feature or request

Comments

@andrewkroh
Copy link
Member

I'm interested in having the /search endpoint return the constraints (Kibana requirements) and owner (maintaining Github team). This would be useful information to have when filtering on the search results.

For example with elastic-package status, which uses /search to collect information on the status of packages in the registry, this data could be included in the output (or used to filter). It might be used to determine what packages are exclusively available in 7.N, but are not in production.

The fields would need moved to BasePackage (or a separate SearchResponse type could be created).

package-registry/util/package.go

Lines 73 to 74 in 89b3dd2

// BasePackage is used for the output of the package info in the /search endpoint
type BasePackage struct {

@andrewkroh andrewkroh added enhancement New feature or request discussion labels Sep 22, 2021
andrewkroh added a commit to andrewkroh/package-registry that referenced this issue Sep 22, 2021
@andrewkroh
Add 'constraints' and 'owner' to /search responses
3799d41 
This adds the constraints.kibana.version and owner fields to /search responses.

It also removes HTML escaping from the JSON responses to make them more readable.

Closes elastic#731
@andrewkroh andrewkroh mentioned this issue Sep 22, 2021
Merged
mtojek pushed a commit that referenced this issue Sep 30, 2021
@andrewkroh
Add 'constraints' and 'owner' to /search responses (#734)
85a31cf 
This adds the constraints.kibana.version and owner fields to /search responses.

It also removes HTML escaping from the JSON responses to make them more readable.

Closes #731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'constraints' and 'owner' to /search responses andrewkroh/package-registry
1 participant
@andrewkroh