Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If-Modified-Since headers are ignored #755

Closed
jsoriano opened this issue Oct 15, 2021 · 0 comments · Fixed by #756
Closed

If-Modified-Since headers are ignored #755

jsoriano opened this issue Oct 15, 2021 · 0 comments · Fixed by #756
Assignees
@jsoriano
Labels
bug Something isn't working Team:Ecosystem Label for the Packages Ecosystem team

Comments

@jsoriano
Copy link
Member

Since the refactor in handlers in 1.4.0 (#703), the static handler is ignoring the If-Modified-Since header.

Before this version, a 304 status code was returned when static files were requested with this header, since the refactor the file is always returned with a 200 status code, independently of the cache headers.
@jsoriano jsoriano added bug Something isn't working Team:Ecosystem Label for the Packages Ecosystem team labels Oct 15, 2021
@jsoriano jsoriano self-assigned this Oct 15, 2021
@jsoriano jsoriano mentioned this issue Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsoriano jsoriano

Labels
bug Something isn't working Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle Last-Modified/If-Modified-Since headers jsoriano/package-registry
1 participant
@jsoriano