Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Last-Modified/If-Modified-Since headers #756

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Handle Last-Modified/If-Modified-Since headers #756

merged 3 commits into from
Oct 18, 2021

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 15, 2021 •
edited
Loading

Handle headers used to indicate if the server should send the required resource based on its modification time.

Add tests to ensure that this continues to be supported.

Fixes #755.

@jsoriano jsoriano requested a review from mtojek October 15, 2021 17:16
@jsoriano jsoriano self-assigned this Oct 15, 2021
@elasticmachine
Copy link

elasticmachine commented Oct 15, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-18T08:06:03.820+0000

  • Duration: 6 min 6 sec

  • Commit: 054b0a9

Test stats 🧪

Test Results
Failed 0
Passed 125
Skipped 0
Total 125

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jsoriano jsoriano force-pushed the last-modified-headers branch from 502435b to 3d7877d Compare October 15, 2021 17:23
mtojek
mtojek approved these changes Oct 18, 2021
View reviewed changes
packages/http.go Show resolved Hide resolved
packages/http.go Outdated Show resolved Hide resolved
@jsoriano jsoriano merged commit 26fa143 into elastic:master Oct 18, 2021
@jsoriano jsoriano deleted the last-modified-headers branch October 18, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@jsoriano jsoriano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If-Modified-Since headers are ignored
3 participants
@jsoriano @elasticmachine @mtojek