[Fleet] Use capabilities filter on categories endpoint #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Hi @nchaulet , thanks for this PR.
Indeed it is needed to add these new query parameters into categories endpoint to filter the packages.
I started a PR a few days ago to include this query parameter (and spec.min/spec.max query parameters) for the categories endpoint in this other PR #1059.
In any case, this PR could be merged separately since it just adds the capabilities parameter for the endpoint.
It would be just missing a changelog entry. Something like:
- Add new query parameter "capabilities" in categories endpoint #1061
mrodm
reviewed
Jul 25, 2023
Co-authored-by: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
💚 Build Succeeded
History
cc @nchaulet |
mrodm
approved these changes
Jul 25, 2023
3 tasks
mrodm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to get the correct count in Fleet UI we should probably filter on capabilities for
/categoriesendpoint too.That PR does that
Test, the capabilities filter is already unit tested